Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Dockerfile in benchmarks #215

Open
GitSparTV opened this issue Oct 31, 2024 · 1 comment
Open

Broken Dockerfile in benchmarks #215

GitSparTV opened this issue Oct 31, 2024 · 1 comment
Labels
doc Something needs to be clarified or corrected in the documentation problem Something isn't working right due to a (minor) problem question A technical question that has or needs clarification

Comments

@GitSparTV
Copy link

The archive in README for benchmark tests doesn't build successfully.
At the current moment container requires absl, ./build.sh instead of sh build.sh, updated pkg-config, recursive clone of re2 and many other things.

@genivia-inc
Copy link
Member

The Dockerfile worked years ago, but probably needs updating. So I can't guarantee the containerized version. But manually it works fine.

For the manual test, all libraries must be installed first and RE/flex should be built before compiling and running the tests using make and run.sh.

I'm not in a hurry to update the Dockerfile, which was just included for convenience, since the tests can be run on a Linux box w/o container. Maybe I should remove the Dockerfile if it's not maintainable.

@genivia-inc genivia-inc changed the title Broken benchmarks Broken Dockerfile in benchmarks Nov 6, 2024
@genivia-inc genivia-inc added question A technical question that has or needs clarification problem Something isn't working right due to a (minor) problem doc Something needs to be clarified or corrected in the documentation labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Something needs to be clarified or corrected in the documentation problem Something isn't working right due to a (minor) problem question A technical question that has or needs clarification
Projects
None yet
Development

No branches or pull requests

2 participants