Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge stroke gradients and contribution changes #3

Open
LacombeJ opened this issue Nov 30, 2023 · 2 comments
Open

Edge stroke gradients and contribution changes #3

LacombeJ opened this issue Nov 30, 2023 · 2 comments

Comments

@LacombeJ
Copy link

Hi, I noticed that edge stroke gradients functionality is in the code but is commented out. Is there a reason why?

I have been working on port and edge coloring and found that I've been making some small changes to GraphViewBase to get things working. Is this repo open to submit pull request?
@Doppelkeks
Copy link
Contributor

Doppelkeks commented Nov 30, 2023 •
edited
Loading

Uh, good question. If I remember correctly, it was just not needed at the time for NewGraph. I really appreciate any pull request, so send them in and I'll check if the pull request is compatible. :)

@LacombeJ LacombeJ mentioned this issue Dec 1, 2023
Open
@LacombeJ
Copy link
Author

LacombeJ commented Dec 1, 2023

@Doppelkeks I submitted a PR. There could be possibly more work to be done since Edge.cs currently resets InputColor and OutputColor on edge selection. In my graph editor I override this to only set EdgeWidth on selected but I didn't touch this since NewGraph styling relies on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Doppelkeks @LacombeJ