-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple replies for the same request breaks requests handling #275
Comments
@giohappy we have to modify accordingly the LayerUploaderTask which is a subclass of network.NetworkRequestTask because during the layer upload, the plugin raises an error because of the following line: https://github.com/GeoNode/QGISGeoNodePlugin/blob/main/src/qgis_geonode/apiclient/geonode_v3.py#L639 |
@Gpetrak this could probably be refactored to avoid repeating the pattern? From a quick look it seems most part of that method is the same as the base class. |
yes, go ahead @Gpetrak |
[Fixes #275] Handle multiple replies generated for same request
We have noticed that sometimes QGIS (Qt) returns multiple replies for the same request, but only the first one contains valid content.
This was observed, for example, when the QGIS network cache is forcibly emptied (from the UI).
This behaviour doesn't depend on the plugin. It's also observed for other network providers (e.g. WMS) and without the GeoNode plugin loaded.
A workaround is to only parse the first reply for the same request, and disregard the next ones.
The text was updated successfully, but these errors were encountered: