[AND-254] Fix polls not respecting [disabled] from dashboard. #5562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
We are currently showing the "Poll" attachment option even if it is disabled from the dashboard. If a user attempts to send a poll in this state, it will result in an error.
This PR includes a check for
channel.config.polls == true
before the "Polls" attachment is added to the "AttachmentPicker"🛠 Implementation details
tabFactories
in theAttachmentsPicker
against the channel capabilities, to ensure that no disallowed factories are shown.Channel
in the attachments picker: ExposepollsEnabled
in theMessageComposerState
and add it to thearePollsEnabled
check in theMessageComposerView
🎨 UI Changes
before.mp4
after.mp4
🧪 Testing
Polls disabled
Polls enabled