bug fix for Clicking on Certain Areas of Audio Recording in Message List Displays "Invalid URL" Error #5449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIPlearner
changed the title
JcMinarro
approved these changes
Oct 22, 2024
Clicking on Certain Areas of Audio Recording in Message List Displays "Invalid URL" Error
JcMinarro
force-pushed
the
fix/clicking-certain-areas-of-recording-causes-invalid-url
branch
from
d806fff
to
84f8dd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on Certain Areas of Audio Recording in Message List Displays "Invalid URL" Error
🎯 Goal
fix for this issue #5446
🛠 Implementation details
basically check to make sure the attachment is unsupported before showing error message
🧪 Testing
Try tapping random places in the message bubble try to avoid buttons and the slider the toast should not appear
🎉 GIF