Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix message transformer not being applied when editing a message #3602

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

nuno-vieira
Copy link
Member

@nuno-vieira nuno-vieira commented Feb 21, 2025

🔗 Issue Links

IOS-709

🎯 Goal

Fix the message transformer not being applied when editing a message.

🧪 Manual Testing Notes

N/A. Covered by unit tests.

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@nuno-vieira nuno-vieira added the 🐞 Bug An issue or PR related to a bug label Feb 21, 2025
@nuno-vieira nuno-vieira requested a review from a team as a code owner February 21, 2025 14:52
Copy link

github-actions bot commented Feb 21, 2025

1 Warning
⚠️ Please be sure to complete the Contributor Checklist in the Pull Request description

Generated by 🚫 Danger

@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.02 MB 7.02 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@Stream-SDK-Bot
Copy link
Collaborator

SDK Performance

target metric benchmark branch performance status
MessageList Hitches total duration 10 ms 15.85 ms -58.5% 🔽 🔴
Duration 2.6 s 2.55 s 1.92% 🔼 🟢
Hitch time ratio 4 ms per s 6.23 ms per s -55.75% 🔽 🔴
Frame rate 75 fps 78.2 fps 4.27% 🔼 🟢
Number of hitches 1 1.0 0.0% 🟰 🟢

@nuno-vieira nuno-vieira enabled auto-merge (squash) February 21, 2025 15:02
@Stream-SDK-Bot
Copy link
Collaborator

SDK Size

title develop branch diff status
StreamChat 7.02 MB 7.02 MB 0 KB 🟢
StreamChatUI 4.77 MB 4.77 MB 0 KB 🟢

@nuno-vieira nuno-vieira merged commit e274d6c into develop Feb 21, 2025
14 checks passed
@nuno-vieira nuno-vieira deleted the fix/apply-transformer-when-editing-message branch February 21, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug An issue or PR related to a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants