-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop fatih/structs #90
Comments
@ferhatelmas I am looking to start contribution to go-lang projects right now. Since this is marked as "good first issue", I plan to take a stab at it. |
@nchetan awesome, idea is to drop dependency and implement the existing functionality with standard library ( |
Do you have documentation on how to build the code base and how to execute it? The README is very user centric and not contribution centric. Please help (I will try and figure this out till you answer back. Will leave a note if am successful) |
Yes. I have.. Is there a way to sync on slack or another software instead of conversations here? I can be reached on email, slack, phone, skype, FB messenger etc. I am based in Pacific Standard Time. |
@ferhatelmas Also, to see an alternative approach, check if https://play.golang.org/p/1sJ3YT7pPiA works for you. This approach doesn't use reflect. If the approach does not work for any reason, please let me know what is missing? |
For comparison, I also created https://play.golang.org/p/0KeJ4rej1p9 (Note: This doesn't create a finished JSON. Just a showcase). |
@ferhatelmas I am still waiting for a response. Thoughts? |
@ferhatelmas If I don't hear back from you in next couple of days, I will assume that this is not a priority issue and drop this issue and continue looking for other places to contribute. |
Here's the update code right now. @ferhatelmas |
@nchetan Yes, it's not a priority. However, we can work on it slowly in that direction. Regarding play links, they are fine for a quick show but a PR would be better for a bigger change. Moreover, there are issues in the implementation and idea because we want to use I have a similar PR here: GetStream/stream-chat-go#84 |
It's not supported anymore, good to refactor its usage and drop.
see #85 #89 for an issue caused by it in nested structs.
The text was updated successfully, but these errors were encountered: