Reafactoring Tables

[SKuipers]

Along with our ongoing refactoring, we've been updating the HTML tables in Gibbon to use a set of PHP classes. This gives us the flexibility to add in better pagination, filtering and sorting, as well as make them mobile-responsive (soon!).

Table OOification is likely the most complicated refactoring so-far. For beginners, see #696 and #820 for a great starting point. Otherwise, give a shout with any questions, since the docs likely don't cover every use case 😅

 

Info

Here's some info if you'd like to help refactor some tables in Gibbon:

👀 Check out the ooification guide or the codebase for examples

👇 Pick a module that hasn't been started yet

💬 Reply here to let us know which module you're working on. We can also invite you to join the tracker spreadsheet, send an email to: [email protected]

PR your changes when they're done, ideally one PR per module. More info here.

 

Additional Modules

• Alumni - @leofreitas
• ATL
• Badges - @jimbo8098
• Credentials - @leofreitas
• Class Enrolment
• Clinics
• Committees
• Course Selection
• Credentials
• Data Admin - @SKuipers
• Feed
• Flexible Learning
• Free Learning
• Help Desk
• Higher Education
• House Points - @jimbo8098
• IB Diploma - @powertashton
• Info Grid - @jimbo8098
• Mastery Transcript
• Meet The Teacher
• Moodle
• Policies - @leofreitas
• Query Builder - @SKuipers
• Stream
• Trip Planner - @jimbo8098

[rossdotparker]

Great work here Sandra. Hopefully this proves as well attendance as the breadcrumbs work: certainly this model of openly and clearly sharing the scope of the work and requesting input, seems like a great way to go. Is it worth adding a link to the list of core tables that we are working on too?

[SKuipers]

Yep! Many of the core tables have varying difficulties from “seems okay” to “absolutely ridiculous” 😆 so I’m going to take a look and triage them a bit more before adding to the list.

[leofreitas]

Hi, I made my first Table OOification in module Policies (GibbonEdu/module-policies#3).

[SKuipers]

Awesome, thanks Leo! I'm going to check it out this afternoon 👍

[jimbo8098]

I'm gonna steal badges if you guys are ok with that?

[rossdotparker]

I'm gonna steal badges if you guys are ok with that?

Jump right in @jimbo8098!

[jimbo8098]

On it! You guys really have been busy!

[jimbo8098]

Badges has been completed as of yesterday fyi. A PR is awaiting approval for it atm. I did need to update core to add the domain for the module but both PRs are merged with master and v18.0.00 as the case may be.

[jimbo8098]

Working on Info Grid now

[SKuipers]

Awesome, thanks!

[jimbo8098]

Finished info grid GibbonEdu/module-infoGrid#6

[jimbo8098]

Gonna grab house points next.

[jimbo8098]

Must admit, kind of left this be after my last post due to other projects, however going to work on House Points today. Long time coming!

[SKuipers]

Awesome 😃 There were some unreleased changed on the House Points develop branch, so I've noted these in the changelog and pushed a v1.3.02 release. https://github.com/SKuipers/gibbon-house-points

[leofreitas]

I'm finishing Credentials. PR in next week!

[SKuipers]

I'm finishing Credentials. PR in next week!

Brilliant, thanks!!

[jimbo8098]

If I'm not mistaken, it seems like the Help Desk module is already converted over to DataTables. I couldn't find any tables tags within that module.

[powertashton]

@jimbo8098: If I'm not mistaken, it seems like the Help Desk module is already converted over to DataTables. I couldn't find any tables tags within that module.

@raynichc and I completely refactored the whole module, so you'd be right on that one.

[SKuipers]

Yes, well spotted, I've checked the Help Desk off on the list 😄

[jimbo8098]

FYI I've started work on the Trip Planner module's trips_manage.php page @raynichc

[leofreitas]

Hi, finished Alumni.

[SKuipers]

Hi, finished Alumni.

Thanks Leo! 👍

[yookoala]

Questions about the remaining modules:

1. IB Diploma module is archived. Does it still needed to be refactored?
2. Is there any link to the source code of "Course Selection"?
3. Seems all left in ATL to refactor is alt_write.php and moduleFunctions.php, correct?