From 8528c5ad5a4a6bbd4d16f17b9b05627db9153d67 Mon Sep 17 00:00:00 2001
From: Luca BRUNO <lucab@lucabruno.net>
Date: Sat, 6 Jan 2024 18:34:39 +0100
Subject: [PATCH] globwalker: avoid spurious allocations in iterator

This tweaks the `GlobWalker` iterator logic in order to avoid
a spurious allocation for each processed directory entry (including
ignored ones).

Verified by running the current testsuite under `heaptrack` and
observing allocations stats:

```
$ heaptrack target/debug/deps/globwalk-baseline
[...]
heaptrack stats:
        allocations:            7176
[...]

$ heaptrack target/debug/deps/globwalk-patched
[...]
heaptrack stats:
        allocations:            7081
[...]
```
---
 src/lib.rs | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/lib.rs b/src/lib.rs
index 22c04c5..e6e6875 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -378,14 +378,10 @@ impl Iterator for GlobWalker {
                         // able to recognize the file name.
                         // `unwrap` here is safe, since walkdir returns the files with relation
                         // to the given base-dir.
-                        let path = e
-                            .path()
-                            .strip_prefix(self.ignore.path())
-                            .unwrap()
-                            .to_owned();
+                        let path = e.path().strip_prefix(self.ignore.path()).unwrap();
 
                         // The path might be empty after stripping if the current base-directory is matched.
-                        if let Some("") = path.to_str() {
+                        if path.as_os_str().is_empty() {
                             continue 'skipper;
                         }