Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With the release of jackson-jr record deserialisation should be available and therefore manual mapping should not be necessary #60

Closed
Giovds opened this issue Oct 4, 2024 · 2 comments
Closed

With the release of jackson-jr record deserialisation should be available and therefore manual mapping should not be necessary #60

Giovds opened this issue Oct 4, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Participate in Hacktoberfest hacktoberfest-accepted has-external-dependency Used for when we can not move forward due to external changes required

Comments

@Giovds
Copy link
Owner

Giovds commented Oct 4, 2024 •
edited
Loading

The QueryClient#toSearchResponse() should not be manually mapping the values anymore and could use records instead.
The project uses jackson-jr 2.18 already. The issue is resolved here: FasterXML/jackson-jr#162
@Giovds Giovds added enhancement New feature or request good first issue Good for newcomers hacktoberfest Participate in Hacktoberfest labels Oct 4, 2024
@Giovds Giovds changed the title With the release of jackson-jr record deserialisation should be available which therefore manual mapping should not be necessary With the release of jackson-jr record deserialisation should be available and therefore manual mapping should not be necessary Oct 4, 2024
@RomeoIndiaJulietUniform
Copy link
Contributor

RomeoIndiaJulietUniform commented Oct 5, 2024 •
edited
Loading

Hii @Giovds, I have solved this issue in my local, all the tests are passing. I am creating a PR for this. Attaching Snapshot for better understanding :

Changes

Screenshot from 2024-10-05 12-04-22

Tests

Screenshot from 2024-10-05 12-03-37

Merged
@Giovds Giovds added the has-external-dependency Used for when we can not move forward due to external changes required label Oct 9, 2024
@Giovds
Copy link
Owner Author

Giovds commented Oct 31, 2024

Resolved with #62

@Giovds Giovds closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Participate in Hacktoberfest hacktoberfest-accepted has-external-dependency Used for when we can not move forward due to external changes required
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Giovds @RomeoIndiaJulietUniform