Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 0.7.0-alpha is out #1158

Closed
tlnagy opened this issue May 31, 2018 · 12 comments · Fixed by #1189
Closed

Julia 0.7.0-alpha is out #1158

tlnagy opened this issue May 31, 2018 · 12 comments · Fixed by #1189

Comments

@tlnagy
Copy link
Member

tlnagy commented May 31, 2018

https://github.com/JuliaLang/julia/releases/tag/v0.7.0-alpha

Time to get serious about 0.7 compatibility.

@bjarthur
Copy link
Member

bjarthur commented Jun 9, 2018

the output of this script follows:

----------------------------------------------------------------------
Failing Dependency Tree  for Gadfly
----------------------------------------------------------------------
Gadfly
	Colors
		ColorTypes
			FixedPointNumbers
		FixedPointNumbers
	Compose
		Colors
			ColorTypes
				FixedPointNumbers
			FixedPointNumbers
		DataStructures
		IterTools
	CoupledFields
	DataFrames
		CategoricalArrays
		TranscodingStreams
	DataArrays
	DataStructures
	Distributions
		StatsFuns
	IterTools
	KernelDensity
		Distributions
			StatsFuns
		Optim
			LineSearches
				NLSolversBase
			NLSolversBase
		Interpolations
			ShowItLikeYouBuildIt
			WoodburyMatrices
			AxisAlgorithms
				WoodburyMatrices
			DualNumbers
	Loess
		IterTools
	IndirectArrays
----------------------------------------------------------------------

@bjarthur
Copy link
Member

bjarthur commented Jun 30, 2018

as of today:

----------------------------------------------------------------------
Failing Dependency Tree  for Gadfly
----------------------------------------------------------------------
Gadfly
	Compose
	CoupledFields
	DataFrames
	DataArrays
	Distributions
		StatsFuns
	KernelDensity
		Distributions
			StatsFuns
		Optim
			LineSearches
				NLSolversBase
			NLSolversBase
		Interpolations
			ShowItLikeYouBuildIt
			WoodburyMatrices
			AxisAlgorithms
				WoodburyMatrices
	Loess
	IndirectArrays
----------------------------------------------------------------------

all of Compose's dependencies now work on 0.7. but we probably shouldn't work on that until Gadfly's are too.

note that the recommendation is to drop support for 0.6 when support for 0.7 is added.

@Mattriks
Copy link
Member

Mattriks commented Jul 1, 2018

I have a Julia 0.7 branch for Mattriks/CoupledFields.jl#4

@bjarthur
Copy link
Member

getting closer, but still a lot of Gadfly's dependencies are not yet working on 0.7.

@tlnagy what is your time frame for finishing GiovineItalia/Compose.jl#282 ? would be best not to merge it until have we tag a final julia 0.6 release for both Gadfly and Compose.

----------------------------------------------------------------------
Failing Dependency Tree  for Gadfly
----------------------------------------------------------------------
Gadfly
	Compose
	CoupledFields
	DataFrames
		Reexport
		WeakRefStrings
	DataArrays
		Reexport
	Distributions
		PDMats
			Arpack
	KernelDensity
		Distributions
			PDMats
				Arpack
		Optim
		Interpolations
			ShowItLikeYouBuildIt
			AxisAlgorithms
	Loess
	IndirectArrays
	WeakRefStrings
----------------------------------------------------------------------

@tlnagy
Copy link
Member Author

tlnagy commented Jul 29, 2018

It's getting there, I just made another stab at it, but ran into some problems: GiovineItalia/Compose.jl#282 (comment). Basically, the code we used to optional precompilation-time loading of optional dependency glue code is broken on v0.7 and the runtime-equivalent from Requires.jl isn't currently working.

@tlnagy
Copy link
Member Author

tlnagy commented Aug 17, 2018

Compose.jl is now passing tests on v1.0 (see GiovineItalia/Compose.jl#282 (comment))

@bjarthur
Copy link
Member

----------------------------------------------------------------------
Failing Dependency Tree  for Gadfly
----------------------------------------------------------------------
Gadfly
	Compose
	DataArrays
----------------------------------------------------------------------

@bjarthur
Copy link
Member

DataArrays.jl looks like it might soon be deprecated, so this might be the time to reduce Gadfly's dependency on it.

JuliaStats/DataArrays.jl#304 (comment)
JuliaStats/DataArrays.jl#301 (comment)

@tlnagy
Copy link
Member Author

tlnagy commented Aug 21, 2018

I'm definitely for dropping DataArrays support. Does someone want to start a PR updating Gadfly for 1.0? Checking GiovineItalia/Compose.jl#282 out should help with that. If no one gets to it first, I'll get to it when I'm back from vacation in a week

@kilianbreathnach
Copy link

kilianbreathnach commented Sep 11, 2018

There is a DataArrays branch named "jq/1.0" that supports v1.0. I have been trying to get Gadfly compiled in v0.7 (in order to make split violin plots that don't fail with the KDE precision problem, as discussed in #1157) and it seems happy with that version of DataArrays but is still not fully working... There seems to be an error with the varset macro when compiling:

ERROR: LoadError: LoadError: LoadError: type LineNumberNode has no field head
Stacktrace:
 [1] getproperty(::Any, ::Symbol) at ./sysimg.jl:18
 [2] @varset(::LineNumberNode, ::Module, ::Symbol, ::Any) at /home/kilian/.julia/packages/Gadfly/Vi3qB/src/varset.jl:25
 [3] include at ./boot.jl:317 [inlined]
 [4] include_relative(::Module, ::String) at ./loading.jl:1038
 [5] include at ./sysimg.jl:29 [inlined]
 [6] include(::String) at /home/kilian/.julia/packages/Gadfly/Vi3qB/src/Gadfly.jl:3
 [7] top-level scope at none:0
 [8] include at ./boot.jl:317 [inlined]
 [9] include_relative(::Module, ::String) at ./loading.jl:1038
 [10] include(::Module, ::String) at ./sysimg.jl:29
 [11] top-level scope at none:2
 [12] eval at ./boot.jl:319 [inlined]
 [13] eval(::Expr) at ./client.jl:399
 [14] top-level scope at ./none:3
in expression starting at /home/kilian/.julia/packages/Gadfly/Vi3qB/src/data.jl:1
in expression starting at /home/kilian/.julia/packages/Gadfly/Vi3qB/src/data.jl:1
in expression starting at /home/kilian/.julia/packages/Gadfly/Vi3qB/src/Gadfly.jl:94

LoadError: LoadError: Failed to precompile Gadfly [c91e804a-d5a3-530f-b6f0-dfbca275c004] to /home/kilian/.julia/compiled/v0.7/Gadfly/DvECm.ji.

There are not many similar errors when I google about the LineNumberNode, so I don't really understand the problem here.

@tlnagy
Copy link
Member Author

tlnagy commented Sep 12, 2018

Is there a specific reason you need DataArrays support? I'm planning to rebase #1157 on master when support for 1.0 is finalized in #1189. We're really close now. Basically the moment we can nail down the CI errors, we'll be merging.

@kilianbreathnach
Copy link

I didn't need it. My solution in the end was to fork #1189 from @bjarthur and merge #1157 with it so that I could get split violin plots working sooner (hoping to get them into a publication at the moment). Looking forward to the official version coming out, you guys are doing amazing work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants