This repository has been archived by the owner on Sep 20, 2022. It is now read-only.
Fix logging so that error details are output to console. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeGinnivan
reviewed
Jul 2, 2018
| @@ -83,7 +86,7 @@ public static int Main(string[] args) | |||
| catch (Exception ex) | |||
| { | |||
| exitCode = -2; | |||
| Log.WriteLine("An unexpected error occurred: {0}", ex.Message); | |||
| Log.WriteLine("An unexpected error occurred: {0}", ex.GetBaseException().Message); | |||
There was a problem hiding this comment.
Should catch aggregate exceptions specifically to do this. Just in case it's not an aggregate exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains two changes:
Logwas set to a CustomLog rather than the expected ConsoleLog.