Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter for specific attester organization on UI #177

Open
5 tasks
divine-comedian opened this issue Sep 24, 2024 · 10 comments
Open
5 tasks

filter for specific attester organization on UI #177

divine-comedian opened this issue Sep 24, 2024 · 10 comments
Assignees

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Sep 24, 2024

Showing to the user when we have applied filtering for a specific attester group that the user knows they are sorting by most vouches from given attester organizations.
Image

AC

on the all projects page:

  • when filtering by source platform the filter selection component is shown above list of projects
  • when filtering by attester org the filter selection component is shown above list of projects
  • the filtered item selected from drop down filter menu matches the one shown in the component text
  • can remove a filter by clicking the x on the filter component
  • removing the filter from the drop down menu also removes the corresponding filter component
@mateodaza mateodaza self-assigned this Oct 17, 2024
@mateodaza
Copy link
Member

Linking this issue here as reference from the backend

@mateodaza mateodaza moved this from Design to In progress in DeVouch Oct 17, 2024
@divine-comedian
Copy link
Contributor Author

@Tosinolawale what does this design look like if multiple sources and groups are filtered for? How does it handle overflow if we fill up the whole line block with filter conditions?
i.e. Imagine the possible filter conditions

Attested By: Gitcoin Passport Holders, Optimism Badgeholders, Giveth Verifiers From: Retro Funding 4, Retro Funding 5, Gitcoin, Giveth

@mateodaza
Copy link
Member

@Tosinolawale does this design make sense if we add more than one organization on the filter?

@Tosinolawale
Copy link

@Tosinolawale what does this design look like if multiple sources and groups are filtered for? How does it handle overflow if we fill up the whole line block with filter conditions? i.e. Imagine the possible filter conditions

Attested By: Gitcoin Passport Holders, Optimism Badgeholders, Giveth Verifiers From: Retro Funding 4, Retro Funding 5, Gitcoin, Giveth

@divine-comedian @mateodaza that Page itself is a component variant which detailed the multiple selection states and overflow. I should have shown the different states clearly.
I have shown the separate states here
Filter
https://www.figma.com/design/QBvhJZY3C93a8NKqcMnEHX/DeVouch?node-id=8310-13429&t=IKoPfB4QtGGSnX17-1

@divine-comedian
Copy link
Contributor Author

@mateodaza - I think we pushed this out too with the latest changes to sorting / filtering - can you confirm if its ready for QA?

@mateodaza
Copy link
Member

@mateodaza - I think we pushed this out too with the latest changes to sorting / filtering - can you confirm if its ready for QA?

Yep I think @LatifatAbdullahi already did it. If not, it's ready for QA

@divine-comedian divine-comedian moved this from In progress to QA in DeVouch Nov 20, 2024
@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Nov 21, 2024

  • When filtering by source platform the filter selection component is shown above list of projects - Pass
  • When filtering by attester org the filter selection component is shown above list of projects - Pass
  • The filtered item selected from drop down filter menu matches the one shown in the component text - Pass
  • Removing a filter by clicking the x on the filter component - Pass
  • Removing the filter from the drop down menu also removes the corresponding filter component - Pass

@mateodaza

UI issues

Staging

dhj

Design

k

uuu

  • In the "Sort by" section the font weight of the selected option should be 700
  • The background of the Filter selection component should not be white, please check the design above
  • The Filter selection component in the Design, there is no colon (please remove the colon)
  • In the Design there is no search bar component @Tosinolawale @divine-comedian (Are we removing the Search bar component?)
  • From the design, when Users select 3 or more Source platforms to be filtered, we should have atmost 3 filter tags in a single line, same goes for filtering Attested Org (Currently, if we have 3 or more tags, only 2 tags are in a single line instead of 3)

@divine-comedian
Copy link
Contributor Author

The search bar is definitely staying on that page

@Tosinolawale can you confirm the position of the search bar is correct?
@mateodaza I'll let you take a look and correct the other UI issues reported.

@Tosinolawale
Copy link

The search bar is definitely staying on that page

@Tosinolawale can you confirm the position of the search bar is correct? @mateodaza I'll let you take a look and correct the other UI issues reported.
Component 1
@mateodaza @LatifatAbdullahi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

No branches or pull requests

5 participants