Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new endaoment projects into DB #4718

Open
7 tasks
divine-comedian opened this issue Sep 10, 2024 · 25 comments
Open
7 tasks

add new endaoment projects into DB #4718

divine-comedian opened this issue Sep 10, 2024 · 25 comments
Assignees
Labels
QF Quadratic Funding Related

Comments

@divine-comedian
Copy link
Contributor

divine-comedian commented Sep 10, 2024

A few Endaoment projects not on our original list of imported projects have requested to be added into the app, we'll need to fetch these projects by their Endaoment ID, parse the project information, assign the correct categories and banners. This is related to the current QF round.

then we need to write a migration to add them into the DB

AC

testing these 8 projects on PRODUCTION

this criteria is met:

  • project banner shows correctly (referenced below each banner for each project)
  • project categories show correctly on UI
  • description shows correctly
  • can access donate page and make successful donation
  • project title shows correctly
  • delivered by endaoment related banners and badges show on project card and project details pages
@divine-comedian divine-comedian added the QF Quadratic Funding Related label Sep 10, 2024
@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Sep 10, 2024
@WhyldWanderer
Copy link

WhyldWanderer commented Sep 10, 2024

Here are the projects that should be added:

Ukraine America Initiative
https://app.endaoment.org/orgs/88-2280006
Project ID: 0ede481a-c59c-4201-8b0c-69e375cdd7ea
Category: Disaster Preparedness and Relief Services

Reef Guardians Hawaii
https://app.endaoment.org/orgs/47-3975420
Project ID: 2627e4ee-f713-4298-84d2-9fbad53d9ed9
category: Water Resource, Wetlands Conservation and Management

Mindfulness Through Play
https://app.endaoment.org/orgs/82-4211804
Project ID: 2d257c44-c39e-4f41-b4b4-24dd732f545d
Category: Student Services and Organizations

SOLUTIONS PROJECT INC
https://app.endaoment.org/orgs/46-3811348
Project ID: a60836a2-f06e-4b5b-9354-584a4ca5b4b0
Category: Energy Resources Conservation and Development

Peace Winds America
https://app.endaoment.org/orgs/26-3744952
Project ID: 25b2e4a9-20de-4564-be24-fc523a22d65c
Category: Disaster Preparedness and Relief Services

Love Justice International
https://app.endaoment.org/orgs/71-0982808
Project ID: c8101dbe-f308-425c-a0a5-39a98316c02f
Category: Victims' Services

Metagovernance Project Inc
https://app.endaoment.org/orgs/85-3442527
Project ID: d94cdffb-50cc-4127-806d-051b26f5ce00
Category: Computer Science

@WhyldWanderer
Copy link

I will start to work on creating these projects and then transfer ownership to the endaoment profile.

I will update this issue when Im done and then the only thing we will need a dev for is to add the categories once the projects are created as I cannot add the endaoment category through the UI.

@divine-comedian divine-comedian moved this from New Issues to Product Research in All-Devs Sep 10, 2024
@WhyldWanderer
Copy link

WhyldWanderer commented Sep 10, 2024

The projects have been created! @CarlosQ96 do you think you can help us to make these projects as imported as well as add the "Endaoment" category to each one?

Ukraine America Initiative

https://giveth.io/project/ukraine-america-initiative

Reef Guardians Hawaii

https://giveth.io/project/reef-guardians-hawaii

Mindfulness Through Play

https://giveth.io/project/mindfulness-through-play

SOLUTIONS PROJECT INC

https://giveth.io/project/solutions-project-inc

Peace Winds America

https://giveth.io/project/peace-winds-america

Love Justice International

https://giveth.io/project/love-justice-international

Metagovernance Project Inc

https://giveth.io/project/metagovernance-project-inc

@WhyldWanderer
Copy link

Also.. should there be a restricted token list for these projects @divine-comedian?

@CarlosQ96 CarlosQ96 moved this from Product Research to In Progress in All-Devs Sep 11, 2024
@divine-comedian
Copy link
Contributor Author

Also.. should there be a restricted token list for these projects @divine-comedian?

No restriced token list!

The only thing left is to add the endaoement category to these projects, correct? I assume @CarlosQ96 is working on it.

@CarlosQ96
Copy link
Collaborator

@WhyldWanderer added isImported to adminJs and the ability to add categories.

@CarlosQ96
Copy link
Collaborator

Will investigate the socials issue now. Didn't find anything wrong, might be a frontend issues. But not sure yet.

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Sep 19, 2024

I've made Giveth/impact-graph#1882 to follow up this bug report

testing these projects now it seems all of their categories are missing from the UI
image

Here's another Endaoment project for comparison - you can see the categories show up including the Endaoment category
https://giveth.io/project/East-Bay-Food-Justice-Project

@CarlosQ96
Copy link
Collaborator

@divine-comedian we have to add their categories. They weren't added. I gotta release this to prod tomorrow.

@divine-comedian

This comment has been minimized.

@divine-comedian
Copy link
Contributor Author

@LatifatAbdullahi this should be ready for QA

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Oct 4, 2024

@CarlosQ96 @divine-comedian

Test update

Ukraine America Initiative

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Pass
Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Reef Guardians Hawaii

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Failed

x

Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Mindfulness Through Play

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Pass
Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

SOLUTIONS PROJECT INC

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Pass
Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Peace Winds America

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Failed (Wrong description)

l

ii

Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Love Justice International

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Pass
Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Metagovernance Project Inc

Project banner shows correctly - Pass
Project categories show correctly on UI - Failed (Category missing)
Description shows correctly - Pass
Can access donate page - Pass
Make successful donation - Pass
Project title shows correctly - Pass
Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

@divine-comedian divine-comedian moved this from QA to Product Backlog in All-Devs Oct 6, 2024
@divine-comedian
Copy link
Contributor Author

Thanks @LatifatAbdullahi so the categories still seem to be missing on these extra projects.

Also there needs to be some parsing of the information to handle line breaks in the raw text - @CarlosQ96 can you handle the categories? Who is the best person to check-out handling the line breaks? @mohammadranjbarz I think you worked on this originally.

@CarlosQ96
Copy link
Collaborator

@divine-comedian Ill set up the categories today.

@CarlosQ96
Copy link
Collaborator

All should be updateble from adminjs @divine-comedian thats the update I did even categories.

@CarlosQ96
Copy link
Collaborator

@LatifatAbdullahi @divine-comedian I added the category endaoment to all of them

@CarlosQ96
Copy link
Collaborator

Hmm not sure of the line breaks and stuff @RamRamez @mohammadranjbarz do you know?

@mohammadranjbarz
Copy link
Contributor

Hmm not sure of the line breaks and stuff @RamRamez @mohammadranjbarz do you know?

I will DM you

@mohammadranjbarz
Copy link
Contributor

@CarlosQ96 @divine-comedian

Test update

Ukraine America Initiative

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Reef Guardians Hawaii

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Failed

x

Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Mindfulness Through Play

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

SOLUTIONS PROJECT INC

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Peace Winds America

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Failed (Wrong description)

l

ii

Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Love Justice International

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

Metagovernance Project Inc

Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

I would appreciate it if besides sending screenshots put the links in the issue as well, it would help us to troubleshoot better when have the link, if I'm not wrong we have this project

https://giveth.io/project/peace-winds-america

and the real project info in endqaoment is
https://app.endaoment.org/orgs/26-3744952

And the decription is wrong in our DB, am I right?

Now I have a question: who and how this project has been added because I couldn't find this project in the CSV that @divine-comedian had passed it to me before

@divine-comedian
Copy link
Contributor Author

@CarlosQ96 @divine-comedian
Test update
Ukraine America Initiative
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
Reef Guardians Hawaii
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Failed
x
Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
Mindfulness Through Play
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
SOLUTIONS PROJECT INC
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
Peace Winds America
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Failed (Wrong description)
l
ii
Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
Love Justice International
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass
Metagovernance Project Inc
Project banner shows correctly - Pass Project categories show correctly on UI - Failed (Category missing) Description shows correctly - Pass Can access donate page - Pass Make successful donation - Pass Project title shows correctly - Pass Delivered by Endaoment related banners and badges show on project card and project details pages - Pass

I would appreciate it if besides sending screenshots put the links in the issue as well, it would help us to troubleshoot better when have the link, if I'm not wrong we have this project

https://giveth.io/project/peace-winds-america

and the real project info in endqaoment is https://app.endaoment.org/orgs/26-3744952

And the decription is wrong in our DB, am I right?

Now I have a question: who and how this project has been added because I couldn't find this project in the CSV that @divine-comedian had passed it to me before

These were projects that heard about the QF round and we added them manually on request from Endaoment

@mohammadranjbarz
Copy link
Contributor

@divine-comedian Ok got it, I thouth we had problem on importing projects, so these are just some cases that we should change them manually in DB

Just the Peace winds america has problem, or the are other projects as well?

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Oct 7, 2024

Here are the projects that should be added:

Ukraine America Initiative https://app.endaoment.org/orgs/88-2280006 Project ID: 0ede481a-c59c-4201-8b0c-69e375cdd7ea Category: Disaster Preparedness and Relief Services

Reef Guardians Hawaii https://app.endaoment.org/orgs/47-3975420 Project ID: 2627e4ee-f713-4298-84d2-9fbad53d9ed9 category: Water Resource, Wetlands Conservation and Management

Mindfulness Through Play https://app.endaoment.org/orgs/82-4211804 Project ID: 2d257c44-c39e-4f41-b4b4-24dd732f545d Category: Student Services and Organizations

SOLUTIONS PROJECT INC https://app.endaoment.org/orgs/46-3811348 Project ID: a60836a2-f06e-4b5b-9354-584a4ca5b4b0 Category: Energy Resources Conservation and Development

Peace Winds America https://app.endaoment.org/orgs/26-3744952 Project ID: 25b2e4a9-20de-4564-be24-fc523a22d65c Category: Disaster Preparedness and Relief Services

Love Justice International https://app.endaoment.org/orgs/71-0982808 Project ID: c8101dbe-f308-425c-a0a5-39a98316c02f Category: Victims' Services

Metagovernance Project Inc https://app.endaoment.org/orgs/85-3442527 Project ID: d94cdffb-50cc-4127-806d-051b26f5ce00 Category: Computer Science

@CarlosQ96 thanks, regarding this, seems we still have some missing categories/sub-categories as shown here

uo

Staging
ft

Here is the issue @CarlosQ96

#4825

@CarlosQ96 CarlosQ96 moved this from Product Backlog to QA in All-Devs Nov 7, 2024
@CarlosQ96
Copy link
Collaborator

@divine-comedian can we close this one too? or anything missing here? I think its basically the same issue we had the categories missing.

cc: @LatifatAbdullahi

@LatifatAbdullahi
Copy link

Thanks @CarlosQ96

The Project description for Peace Wind America has been updated as well

ri

@LatifatAbdullahi LatifatAbdullahi moved this from QA to Done in All-Devs Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QF Quadratic Funding Related
Projects
Status: Done
Development

No branches or pull requests

5 participants