-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new endaoment projects into DB #4718
Comments
Here are the projects that should be added: Ukraine America Initiative Reef Guardians Hawaii Mindfulness Through Play SOLUTIONS PROJECT INC Peace Winds America Love Justice International Metagovernance Project Inc |
I will start to work on creating these projects and then transfer ownership to the endaoment profile. I will update this issue when Im done and then the only thing we will need a dev for is to add the categories once the projects are created as I cannot add the endaoment category through the UI. |
Ukraine America Initiativehttps://giveth.io/images/defaultProjectImages/community.png Reef Guardians Hawaiihttps://giveth.io/images/defaultProjectImages/nature.png Mindfulness Through Playhttps://giveth.io/images/defaultProjectImages/education.png SOLUTIONS PROJECT INChttps://giveth.io/images/defaultProjectImages/nature.png Peace Winds Americahttps://giveth.io/images/defaultProjectImages/community.png Love Justice Internationalhttps://giveth.io/images/defaultProjectImages/community.png Metagovernance Project Inc |
The projects have been created! @CarlosQ96 do you think you can help us to make these projects as imported as well as add the "Endaoment" category to each one? Ukraine America Initiativehttps://giveth.io/project/ukraine-america-initiative Reef Guardians Hawaiihttps://giveth.io/project/reef-guardians-hawaii Mindfulness Through Playhttps://giveth.io/project/mindfulness-through-play SOLUTIONS PROJECT INChttps://giveth.io/project/solutions-project-inc Peace Winds Americahttps://giveth.io/project/peace-winds-america Love Justice Internationalhttps://giveth.io/project/love-justice-international Metagovernance Project Inc |
Also.. should there be a restricted token list for these projects @divine-comedian? |
No restriced token list! The only thing left is to add the endaoement category to these projects, correct? I assume @CarlosQ96 is working on it. |
@WhyldWanderer added isImported to adminJs and the ability to add categories. |
Will investigate the socials issue now. Didn't find anything wrong, might be a frontend issues. But not sure yet. |
I've made Giveth/impact-graph#1882 to follow up this bug report testing these projects now it seems all of their categories are missing from the UI Here's another Endaoment project for comparison - you can see the categories show up including the Endaoment category |
@divine-comedian we have to add their categories. They weren't added. I gotta release this to prod tomorrow. |
This comment has been minimized.
This comment has been minimized.
@LatifatAbdullahi this should be ready for QA |
Test update Ukraine America Initiative Project banner shows correctly - Pass Reef Guardians Hawaii Project banner shows correctly - Pass Can access donate page - Pass Mindfulness Through Play Project banner shows correctly - Pass SOLUTIONS PROJECT INC Project banner shows correctly - Pass Peace Winds America Project banner shows correctly - Pass Can access donate page - Pass Love Justice International Project banner shows correctly - Pass Metagovernance Project Inc Project banner shows correctly - Pass |
Thanks @LatifatAbdullahi so the categories still seem to be missing on these extra projects. Also there needs to be some parsing of the information to handle line breaks in the raw text - @CarlosQ96 can you handle the categories? Who is the best person to check-out handling the line breaks? @mohammadranjbarz I think you worked on this originally. |
@divine-comedian Ill set up the categories today. |
All should be updateble from adminjs @divine-comedian thats the update I did even categories. |
@LatifatAbdullahi @divine-comedian I added the category endaoment to all of them |
Hmm not sure of the line breaks and stuff @RamRamez @mohammadranjbarz do you know? |
I will DM you |
I would appreciate it if besides sending screenshots put the links in the issue as well, it would help us to troubleshoot better when have the link, if I'm not wrong we have this project https://giveth.io/project/peace-winds-america and the real project info in endqaoment is And the decription is wrong in our DB, am I right? Now I have a question: who and how this project has been added because I couldn't find this project in the CSV that @divine-comedian had passed it to me before |
These were projects that heard about the QF round and we added them manually on request from Endaoment |
@divine-comedian Ok got it, I thouth we had problem on importing projects, so these are just some cases that we should change them manually in DB Just the Peace winds america has problem, or the are other projects as well? |
@CarlosQ96 thanks, regarding this, seems we still have some missing categories/sub-categories as shown here Here is the issue @CarlosQ96 |
@divine-comedian can we close this one too? or anything missing here? I think its basically the same issue we had the categories missing. |
Thanks @CarlosQ96 The Project description for Peace Wind America has been updated as well |
A few Endaoment projects not on our original list of imported projects have requested to be added into the app, we'll need to fetch these projects by their Endaoment ID, parse the project information, assign the correct categories and banners. This is related to the current QF round.
then we need to write a migration to add them into the DB
AC
testing these 8 projects on PRODUCTION
this criteria is met:
The text was updated successfully, but these errors were encountered: