-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
when a project is vouched, allow project owner to boost their own project #4814
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
|
Thanks Tosin! I think we can go ahead on this. Adding the warning text when user is VOUCHED and has incomplete givbacks form I don't think its necessary to add the notification dot when the user opens the drop down menu. @kkatusic - Can you take this one on? Here are the requirements: ACWhen project is VOUCHED(verified=true), not givbacks eligible AND has incomplete givbacks form we should:
|
@divine-comedian we are now replacing current message: "Is your project creating or supporting public goods?" |
@kkatusic there should be this copy we can use that replaces this copy you've shown here. You can find the title and description from |
@divine-comedian this is what you want? |
sort of - bear in mind this should ONLY appear when form status is incomplete AND project is vouched AND when project is NOT givbacks eligible. I can see the project you have shown here already has givbacks status of eligible. |
@divine-comedian I changed only inside administration value for eligible status for testing purpose, but form confirmation has been done for this project, that's why it is green. |
ready for QA @LatifatAbdullahi |
Test update 1
This is the UI shown when the project is Givbacks form is incomplete and Project is vouched, instead of the "Boost" button and the updated text from the design shown below. Staging Design 2
3
4
5
6
7 When the Givback form is incomplete, the text here should be "Resume Givbacks Form" not "Givbacks Eligibilty Form" Staging Design |
@LatifatAbdullahi, ccc @divine-comedian , I skipped project status rejection issue but fixed this condition that Mitch requested. Here we have lots of the conditions maybe in future we can refactor this code, every new condition we just add it here :) |
Test Update Thanks @kkatusic
@kkatusic See here |
@divine-comedian All seems good now
|
Currently from the project owner view, when a project is vouched and also has an incomplete GIVbacks eligiblity form they are unable to boost their project from any view on Giveth!
We should reconsider the CTA buttons we use or make the necessary design change to accomodate this scenarion
The text was updated successfully, but these errors were encountered: