Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when a project is vouched, allow project owner to boost their own project #4814

Open
divine-comedian opened this issue Oct 3, 2024 · 14 comments
Assignees

Comments

@divine-comedian
Copy link
Contributor

Currently from the project owner view, when a project is vouched and also has an incomplete GIVbacks eligiblity form they are unable to boost their project from any view on Giveth!

We should reconsider the CTA buttons we use or make the necessary design change to accomodate this scenarion

Image

@github-project-automation github-project-automation bot moved this to New Issues in All-Devs Oct 3, 2024
@divine-comedian divine-comedian moved this from New Issues to Design in All-Devs Oct 3, 2024
@Tosinolawale

This comment was marked as outdated.

@divine-comedian

This comment was marked as resolved.

@Tosinolawale
Copy link

@Tosinolawale to understand the New label shows up if the project has a incomplete form? Maybe we

Can we just make this a small notification dot instead of using the text "New"? Or could we perhaps use a warning color or notification symbol to let them know that they should check out their application is incomplete?
Project Single - About
I introduced a warning/info label under the project actions
https://www.figma.com/design/fHpNMd8Q9iBrAr6kBj9oo5/DeVouch-Giveth-Integration?node-id=8603-16467&t=gtqWMULOww7z7Ga2-1 @divine-comedian

@divine-comedian
Copy link
Contributor Author

divine-comedian commented Nov 3, 2024

Thanks Tosin! I think we can go ahead on this. Adding the warning text when user is VOUCHED and has incomplete givbacks form

I don't think its necessary to add the notification dot when the user opens the drop down menu.

@kkatusic - Can you take this one on? Here are the requirements:

AC

When project is VOUCHED(verified=true), not givbacks eligible AND has incomplete givbacks form we should:

  • show givbacks component header and text for condition of vouched, not givbacks eligible project (including boost button
  • show text under project actions drop down menu to warn user they have incomplete givbacks form
  • when givbacks form is not started, submitted, rejected or approved state we do not show warning text under project actions drop down menu

image

@divine-comedian divine-comedian moved this from Design to Product Backlog in All-Devs Nov 4, 2024
@kkatusic
Copy link
Collaborator

kkatusic commented Nov 7, 2024

@divine-comedian we are now replacing current message: "Is your project creating or supporting public goods?"

Screenshot 2024-11-07 at 14 00 48

@divine-comedian
Copy link
Contributor Author

@kkatusic there should be this copy we can use that replaces this copy you've shown here.

You can find the title and description from verified_owner_not_eligible label in the language json files

@kkatusic
Copy link
Collaborator

kkatusic commented Nov 8, 2024

@divine-comedian this is what you want?

Screenshot 2024-11-08 at 11 43 15

@divine-comedian
Copy link
Contributor Author

sort of - bear in mind this should ONLY appear when form status is incomplete AND project is vouched AND when project is NOT givbacks eligible.

I can see the project you have shown here already has givbacks status of eligible.

@kkatusic
Copy link
Collaborator

kkatusic commented Nov 8, 2024

@divine-comedian I changed only inside administration value for eligible status for testing purpose, but form confirmation has been done for this project, that's why it is green.

@kkatusic kkatusic moved this from Product Backlog to Code Review/PR in All-Devs Nov 8, 2024
@divine-comedian
Copy link
Contributor Author

ready for QA @LatifatAbdullahi

@LatifatAbdullahi
Copy link

LatifatAbdullahi commented Nov 27, 2024

Test update

@kkatusic

1

  • Show givbacks component header and text for condition of vouched, not givbacks eligible project (including boost button) - Pending

This is the UI shown when the project is Givbacks form is incomplete and Project is vouched, instead of the "Boost" button and the updated text from the design shown below.

Staging

88

Design

uii

2

  • Show text under project actions drop down menu to warn user they have incomplete givbacks form - Pass

3

  • When givbacks form is not started we do not show warning text under project actions drop down menu - Pass

4

  • When givbacks form is submitted do not show warning text under project actions drop down menu - Failed

355

5

  • When givbacks form is rejected we do not show warning text under project actions drop down menu - Failed

90

6

  • When givbacks form is approved we do not show warning text under project actions drop down menu - Pass

7

When the Givback form is incomplete, the text here should be "Resume Givbacks Form" not "Givbacks Eligibilty Form"

Staging

000

Design

rss

@kkatusic kkatusic self-assigned this Nov 28, 2024
@kkatusic kkatusic moved this from Code Review/PR to In Progress in All-Devs Nov 28, 2024
@kkatusic kkatusic moved this from In Progress to Code Review/PR in All-Devs Nov 28, 2024
@kkatusic
Copy link
Collaborator

@LatifatAbdullahi, ccc @divine-comedian , I skipped project status rejection issue but fixed this condition that Mitch requested. Here we have lots of the conditions maybe in future we can refactor this code, every new condition we just add it here :)

@LatifatAbdullahi
Copy link

Test Update

Thanks @kkatusic

  • Show givbacks component header and text for condition of vouched, not givbacks eligible project (including boost button) - Pending

  • Show text under project actions drop down menu to warn user they have incomplete givbacks form - Pass

  • When givbacks form is not started we do not show warning text under project actions drop down menu - Pass

  • When givbacks form is submitted we do not show warning text under project actions drop down menu - Pass

  • When givbacks form is approved we do not show warning text under project actions drop down menu - Pass

  • When the Givback form is incomplete, the text here should be "Resume Givbacks Form" not "Givbacks Eligibilty Form" - Pass

  • When givbacks form is rejected we do not show warning text under project actions drop down menu - Skipped(would be covered later on with other conditions)

@kkatusic
This information here has not been updated for when the Givback form has not been completed.

vvv

See here

ji

@LatifatAbdullahi
Copy link

@divine-comedian All seems good now

  • Show givbacks component header and text for condition of vouched, not givbacks eligible project (including boost button) - Pass

  • Show text under project actions drop down menu to warn user they have incomplete givbacks form - Pass

  • When givbacks form is not started we do not show warning text under project actions drop down menu - Pass

  • When givbacks form is submitted we do not show warning text under project actions drop down menu - Pass

  • When givbacks form is approved we do not show warning text under project actions drop down menu - Pass

  • When the Givback form is incomplete, the text here should be "Resume Givbacks Form" not "Givbacks Eligibilty Form" - Pass

  • When givbacks form is rejected we do not show warning text under project actions drop down menu - Skipped(would be covered later on with other conditions)

sf

image

image

@LatifatAbdullahi LatifatAbdullahi moved this from Code Review/PR to Done in All-Devs Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants