Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out a better way to deal with complex elements #592

Open
mariano-dagostino opened this issue Nov 23, 2023 · 0 comments
Open

Figure out a better way to deal with complex elements #592

mariano-dagostino opened this issue Nov 23, 2023 · 0 comments

Comments

@mariano-dagostino
Copy link
Collaborator

The carousel element has 6 parameters to create variations, I think there is room for improvement. There are more options to pass if we want more configs, like items per page, number of rows, etc.

string $title, array $body, array $items, bool $is_featured = FALSE, array $button = NULL, $is_infinite = FALSE

I don't have a final answer to this problem, I've been playing with some ideas about using configuration objects to abstract the logic and keep the number of parameters close to 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant