Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a diferent implementation for Seckit #673

Open
mariano-dagostino opened this issue Jun 10, 2024 · 1 comment
Open

Provide a diferent implementation for Seckit #673

mariano-dagostino opened this issue Jun 10, 2024 · 1 comment

Comments

@mariano-dagostino
Copy link
Collaborator

Problem:

  • The seckit module uses a config file to define the directives of what to allow or block.
  • The config is very complex to review, just a set of lines next each other.
  • It also leaks internal stating or ddev environments.

Proposed solution

  • Implement a SecKitEventSubscriber similar event subscriber.
  • Provide a different, maybe per environment class to use arrays or yaml file with a different structure.
  • Alternatively work in a seckit patch.
@AronNovak
Copy link
Member

@mariano-dagostino I think we should not maintain an alternative way of configuring it, on the long run, it's better if we can provide a patch that helps everyone to do it right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants