Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow scheduler on locked pages (if scheduler module is enabled) #693

Open
mgurjanov opened this issue Jul 25, 2024 · 4 comments · Fixed by #754 · May be fixed by #770
Open

Disallow scheduler on locked pages (if scheduler module is enabled) #693

mgurjanov opened this issue Jul 25, 2024 · 4 comments · Fixed by #754 · May be fixed by #770

Comments

@mgurjanov
Copy link
Collaborator

Issue

Locked pages can be unpublished by setting scheduler on a locked page.

Todo

We should check on locked pages if scheduler is set and show a form error thus preventing locked page to become potentially unpublished.

@sonvir249
Copy link
Contributor

@mgurjanov Can you please provide some context of locked pages? Maybe I can work on this issue. Thanks!

@mgurjanov
Copy link
Collaborator Author

@sonvir249 Hi. Thanks for being active on this project!

We've implemented locked pages feature that is using config_pages module for setting nodes that should be locked from UI. So basically on a LIVE site you go to admin/structure/config_pages and I think within main settings you chose which nodes (landing pages) you want to be locked. Once configured those nodes are not supposed to be deleted by mistake or unpublished etc. This is useful for locking e.g. a site homepage.

This issue needs to cover locked pages feature in relationship to scheduler.

Initial PR for reference: #361 but there were other follow-up PRs.

If in doubt about anything else please let me know.

@sonvir249
Copy link
Contributor

@mgurjanov Thank you so much for the detailed information. I have raised a draft PR. Most of the things are done, just form error part is remaining. Would you mind taking a look at the draft PR 754 ?

@amitaibu amitaibu reopened this Dec 10, 2024
@amitaibu
Copy link
Member

Re-opened since #754 caused main's tests to fail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants