From a754126056b566fa3936f997f8143b1ca13e718a Mon Sep 17 00:00:00 2001 From: Vitor Augusto Pinheiro <26413854+Vitorgus@users.noreply.github.com> Date: Wed, 20 Mar 2024 18:26:21 -0300 Subject: [PATCH 1/2] fix: storage path now accepts space characters --- addons/godot-firebase/storage/storage.gd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/godot-firebase/storage/storage.gd b/addons/godot-firebase/storage/storage.gd index af7c22a..ac371e1 100644 --- a/addons/godot-firebase/storage/storage.gd +++ b/addons/godot-firebase/storage/storage.gd @@ -334,7 +334,7 @@ func _finish_request(result: int) -> void: func _get_file_url(ref: StorageReference) -> String: var url := _extended_url.replace("[APP_ID]", ref.bucket) url = url.replace("[API_VERSION]", _API_VERSION) - return url.replace("[FILE_PATH]", ref.full_path.replace("/", "%2F")) + return url.replace("[FILE_PATH]", ref.full_path.uri_encode()) # Removes any "../" or "./" in the file path. From 869c2a2448b687697e47c0fe234b84bbbd22d2ad Mon Sep 17 00:00:00 2001 From: Vitor Augusto Pinheiro <26413854+Vitorgus@users.noreply.github.com> Date: Fri, 22 Mar 2024 14:53:35 -0300 Subject: [PATCH 2/2] fix: now using proper godot 3 function --- addons/godot-firebase/storage/storage.gd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/godot-firebase/storage/storage.gd b/addons/godot-firebase/storage/storage.gd index ac371e1..bf60d9a 100644 --- a/addons/godot-firebase/storage/storage.gd +++ b/addons/godot-firebase/storage/storage.gd @@ -334,7 +334,7 @@ func _finish_request(result: int) -> void: func _get_file_url(ref: StorageReference) -> String: var url := _extended_url.replace("[APP_ID]", ref.bucket) url = url.replace("[API_VERSION]", _API_VERSION) - return url.replace("[FILE_PATH]", ref.full_path.uri_encode()) + return url.replace("[FILE_PATH]", ref.full_path.http_escape()) # Removes any "../" or "./" in the file path.