Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Functions URL is not taking arguments into account #422

Open
LazyDridri opened this issue Jul 22, 2024 · 1 comment
Open

[BUG] Functions URL is not taking arguments into account #422

LazyDridri opened this issue Jul 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LazyDridri
Copy link

Description
Calling cloud functions is not taking parameters passed through params Dictionary

Location (functions/functions.gd : execute() methods
`
var url : String = _base_url + ("/" if not _base_url.ends_with("/") else "") + function
function_task._url = url

if not params.empty():
	url += "?"
	for key in params.keys():
		url += key + "=" + params[key] + "&"

`

Solution
Replace "url" by "function_task._url" when applying parameters

@LazyDridri LazyDridri added the bug Something isn't working label Jul 22, 2024
@WolfgangSenff
Copy link
Collaborator

Huh, weird. Appreciate the report! Do you want to contribute back to the project and open a PR for this change? Shouldn't be tough I imagine. Just make sure to fork the repo and then make your branch, fix it, make the PR targeting whatever branch you're fixing it on, and I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants