Copying multiple files

[jkawamoto]

FileWatcher only checks when the last DirectoryChangeEvent occurred, and if it did in last 3 sec, skips other processes as the following snippet shows:

goobox-sync-storj/src/main/java/io/goobox/sync/storj/FileWatcher.java

Lines 53 to 57 in a52e4d6

	long currentTime = System.currentTimeMillis();
	if (currentTime < lastEventTime + 3000) {
	// last file event was less then 3 seconds ago
	return;
	}

In this implementation, I think, if a user copies many files at the same time, FileWatcher is going to wait until all file copies are finished.

[kaloyan-raev]

Exactly, this is by design. We also have this:

goobox-sync-storj/src/main/java/io/goobox/sync/storj/CheckStateTask.java

Lines 46 to 51 in a52e4d6

	public void run() {
	// check if there are local file operations in progress
	if (App.getInstance().getFileWatcher().isInProgress()) {
	System.out.println("Skip checking for changes - local file operations in progress...");
	return;
	}

For the moment I want to reduce the risk where the check state task runs on partially copied files. I wanted to have a safe and stable, yet not completely optimal, implementation as the base. We will optimize it later. For the moment, I believe it is enough for the initial community release.

[jkawamoto]

That makes sense and yes, I think it’s enough for now, too.