-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Invoices] Add tools for Super Admins to clean up soft launch Invoices #1040
Comments
GOO-440 [Invoices] Add tools for Super Admins to clean up soft launch Invoices
Here's a quick recap of the current state of Invoices on production:
Here's what we need to do: Super Admins can delete Invoices from WordPressWe need to give Super Admins a way to delete Invoice post types from WordPress. We could add the UI for this either to the Invoices dashboard in the Network Admin, or the Invoices post type view on the NP sites. The specific use-case we're trying to solve for is Anne Marie deleting WordPress Invoices that don't have an associated Stripe invoice, which won't happen moving forward. I don't feel strongly that we need to extend this feature to also delete the associated Stripe Invoice if one exists -- that seems like a separate feature -- but I don't think we want to give Super Admins the ability to only delete the WordPress invoice (without deleting the Stripe invoice) in perpetuity. So, my suggestion is to only expose this option in the UI if the stripe_invoice_id for the invoice is Super Admins can disable Auction invoices for a NonprofitNow that we've fixed the Here's what I'm thinking:
|
Here's a quick recap of the current state of Invoices on production:
Here's what we need to do:
Super Admins can delete Invoices from WordPress
We need to give Super Admins a way to delete Invoice post types from WordPress. We could add the UI for this either to the Invoices dashboard in the Network Admin, or the Invoices post type view on the NP sites.
The specific use-case we're trying to solve for is Anne Marie deleting WordPress Invoices that don't have an associated Stripe invoice, which won't happen moving forward. I don't feel strongly that we need to extend this feature to also delete the associated Stripe Invoice if one exists -- that seems like a separate feature -- but I don't think we want to give Super Admins the ability to only delete the WordPress invoice (without deleting the Stripe invoice) in perpetuity.
So, my suggestion is to only expose this option in the UI if the stripe_invoice_id for the invoice is
null
. That way, Anne Marie can use this feature to clean-up soft launch invoices, and if the need arises for Super Admins to be able to fully delete a WP + Stripe invoice, we can solve for that separately.Super Admins can disable Auction invoices for a Nonprofit
Now that we've fixed the
get_site_option
bug with Invoices, any Auction for any Nonprofit that closes will generate a WP + Stripe Invoice. There are two Auctions still live on production -- one for a NP that GB plans to charge, one for a NP that GB does not plan to charge. We'd like to give Anne Marie the option to "disable" Auction invoices for the NP that GB does not plan to charge, so that the system won't generate a WP + Stripe invoice for that Auction when it closes.Here's what I'm thinking:
The text was updated successfully, but these errors were encountered: