Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site visitors see All Auctions page on Nonprofit Site (See it Work) #39

Closed
clatwell opened this issue Dec 4, 2023 · 12 comments
Closed

Comments

@clatwell
Copy link
Contributor

clatwell commented Dec 4, 2023

Site Visitors need to be able to navigate to an index page of All Auctions for a Nonprofit Site. For this ticket, we want to build out a basic (See it Work) version of the Auctions page. Here's what we need to do:

Page Functionality

  • Slug: /auctions
  • Content: Display all published Auctions for the Nonprofit with Auction Name and Auction Image
    • Auction Name - Auction Post Title
    • Auction Image - Use the featured image for the Auction if it's set. Otherwise, use the Main Product Image for the Prize Product associated with the Auction. If no Main Product Image is set on the Prize Product, WooCommerce will serve up a fallback.
  • Navigation: Add link to Auctions page to the Site Header
  • Interaction: Site Visitors can click the Auction Name or Auction Image to navigate to the Auction page.
  • Sort: By Date Published (ascending)
  • Pagination: 9 Auctions Per Page

Page Design

  • Template: Index Template from 2024
  • Template Modifications:
    • Display a hard-coded page title ("Our Auctions") above list items
    • See image size in this wireframe.
  • Note: The default bg for the Index Template in 2024 has a white background. Felice's 2023 wireframes show a light green background. I think we should go with the white background for now.

Future Enhancements

The purpose of this ticket is just to wire up the most basic version of this page based on the data and functionality we currently have in the system. In a future ticket, we'll circle back to:

  • Filter / sort functionality and updates to default sort
  • Displaying time remaining in the Auction
  • Displaying # of Users watching the Auction
@clatwell clatwell changed the title Site visitors see All Auctions page on Nonprofit Site Site visitors see All Auctions page on Nonprofit Site (See it Work) Dec 11, 2023
@clatwell
Copy link
Contributor Author

@nathan-schmidt-viget and @bd-viget - I'd been thinking that Site Admins would upload an image (or multiple images) of the item being auctioned to the Prize Product for the Auction. However, in thinking about this Auctions page template, I wonder if it actually makes sense to store an Auction image on the Auction Custom Post Type? We can discuss in sprint planning! If so, I'll spin up a quick ticket for Nathan that precedes this one to add an Image field to the Auction Custom Post Type.

Screenshot 2023-12-11 at 9 51 02 AM

@clatwell
Copy link
Contributor Author

@bd-viget's - You can put a featured image on the Auction:

  • Use the featured image for the Auction if it's set
  • If it's not, fall back to the featured image of the product

nathan-schmidt-viget added a commit that referenced this issue Dec 19, 2023
nathan-schmidt-viget added a commit that referenced this issue Dec 19, 2023
nathan-schmidt-viget added a commit that referenced this issue Dec 19, 2023
* [#39] setting up archive page

* [#39] Setting default image for Auction index

* [#39] setting number of post per page on auction index

* [#39] adding auction archive page to nav

* [#39] pattern refactor to use plugin

* [#39] fixing PR edits

* [#39] removing page for menu

* [#39] updating default post per page
@nathan-schmidt-viget
Copy link
Contributor

This is merged and ready for QA - #103

@shascher
Copy link
Contributor

@nathan-schmidt-viget - Did we implement the below on this?

Auction Image - Use the featured image for the Auction if it's set. Otherwise, use the Main Product Image for the Prize Product associated with the Auction. If no Main Product Image is set on the Prize Product, WooCommerce will serve up a fallback.

I'm seeing my featured image for the product and not the Auction on my test. https://goodbids-develop.go-vip.net/charity-water/auctions/

@nathan-schmidt-viget
Copy link
Contributor

@shascher goodcatch, looks like I need to tweak my logic for that a bit.

@clatwell
Copy link
Contributor Author

Movin' and shakin'! Good catch @shascher and thanks for the quick fix @nathan-schmidt-viget!

@shascher
Copy link
Contributor

@nathan-schmidt-viget - I'm not seeing my auctions anymore at /charity-water/auctions, not sure if a recent deploy had an impact or I may just not have them set up right?

@nathan-schmidt-viget
Copy link
Contributor

@shascher let me look and see what is going on.

@nathan-schmidt-viget
Copy link
Contributor

@shascher I don't have access to the charity-water site with my account. But I think it may have to do with the new GoodBids Main theme. I had that problem on my local were WP got all confused. Once I get access to the admin, I can dig into it more.

@shascher
Copy link
Contributor

shascher commented Jan 8, 2024

@nathan-schmidt-viget - I left a comment on this PR as I should be seeing at least one auction at the link below. Maybe related to the error?

https://goodbids-develop.go-vip.net/charity-water/auctions/

@nathan-schmidt-viget
Copy link
Contributor

@shascher Thanks, I got that fixed and up in that same PR. Hopefully can get that up for you soon.

@shascher
Copy link
Contributor

shascher commented Jan 9, 2024

@nathan-schmidt-viget - Looking swell now!

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants