Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drupal uses-responsize-images unclear #54

Open
exterkamp opened this issue Sep 22, 2020 · 2 comments
Open

Drupal uses-responsize-images unclear #54

exterkamp opened this issue Sep 22, 2020 · 2 comments

Comments

@exterkamp
Copy link
Member

The second half of the string https://github.com/GoogleChrome/lighthouse-stack-packs/blob/master/packs/drupal.js#L28 is unclear.

Use the Responsive Image Styles when rendering image fields through view modes, views, or images uploaded through the WYSIWYG editor.',

Are there three ways of rendering an image field? (through a view mode, a view, or via upload from the WYSIWYG editor) Or is the WYSIWYG editor different and is uploading images directly instead of through fields?

This needs to be re-written by someone who knows what all these Drupal terms mean 😄

@paulirish
Copy link
Member

full thing:

Ensure that you are using the native Responsive Image Styles provided from Drupal (available in Drupal 8 and above). Use the Responsive Image Styles when rendering image fields through view modes, views, or images uploaded through the WYSIWYG editor.

cc @moerazem

cc @webchick maybe you can help us out with wording or tag in someone who can?

this text is shown to lighthouse users when analyzing a page that's hosted by drupal. so they should have some familiarity. Perhaps we can remove some of the detail here? does https://www.drupal.org/docs/mobile-guide/responsive-images capture most of what they need to know?

@moerazem
Copy link
Contributor

moerazem commented Jan 27, 2021

I'd say the most common ways of rending images in Drupal are indeed view modes, views, or WYSIWYG embeds.
This terminology should be clear to Drupal developers/site builders.

The reason I wanted to emphasize those three ways, is because it's very common for Drupal developers/site builders to configure Responsive Image Styles on a node/content when displayed in its own page, but skip that (or miss it) when displaying it via a "view". "Views" can also display images through individual "fields" or a "view mode" that includes an image.
Hence, this description to emphasize those various ways to alert Drupal developers/site builders when rendering images.

Any edit/suggestion to make it clearer is also extremely appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants