Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSI ignoring all objects using http/1.1 since Mar 3 #12222

Closed
tferik opened this issue Mar 8, 2021 · 8 comments
Closed

PSI ignoring all objects using http/1.1 since Mar 3 #12222

tferik opened this issue Mar 8, 2021 · 8 comments
Assignees
Labels
P1 pending-close PSI/LR PageSpeed Insights and Lightrider

Comments

@tferik
Copy link

tferik commented Mar 8, 2021

Since the Mar 3 Lighthouse update, we noticed the scores on some of our pages more than doubled. This is more than expected by just the change to support http/2. This particular site - (fishersci.com) is a mixture of http/1.1 and http/2 and it looks like Lighthouse isn't loading any of the resources hosted on the http/1.1 domain any more (beta-static.fishersci.com). So it's not loading any of the .css, .js, fonts and many images, giving a false score. We also noticed that some metrics can't be correct anymore, such as cumalitive layout shift went to 0 for all our pages. I attached an image showing the drastic change in metrics on Mar 3rd for 4 different pages on www.fishersci.com:
https://www.fishersci.com/us/en/home.html
https://www.fishersci.com/us/en/contactus.html
https://www.fishersci.com/shop/products/pyrex-heavy-duty-griffin-beakers-7/0255525A#?keyword=beakers
https://www.fishersci.com/us/en/catalog/search/products?keyword=beakers

Provide the steps to reproduce

  1. From a LH page, such as: https://developers.google.com/speed/pagespeed/insights/ run an analysis on https://www.fishersci.com/us/en/catalog/search/products?keyword=beakers
  2. Notice in the screenshots of the page that none of the stylesheets are present.

What is the current behavior?

  1. None of the resources hosted on beta-static.fishersci.com (http/1.1) are being loaded. Only the resources from www.fishersci.com (http/2) are loaded.

What is the expected behavior?

  1. All the resources should be loaded. It should negotiate http/2 if possible, but revert to http/1.1 otherwise.

Environment Information

  • Affected Channels: DevTools
  • Lighthouse version: 7.1
  • Chrome version: 88.0.4324.190
  • Node.js version:
  • Operating System:
    FS_lighthouse_performance_anomaly
@connorjclark
Copy link
Collaborator

Thanks for the report. We have similar reports already with the same root cause (#12219 #12216), but this issue seems the most useful filed so far so I'll dupe all the others into this.

We're investigating internally. Is there any detail you can share about how the beta-static.fishersci.com server is configured wrt http/1.1 / TLS?

@tferik
Copy link
Author

tferik commented Mar 8, 2021 via email

@connorjclark
Copy link
Collaborator

connorjclark commented Mar 9, 2021

Alright, we think we've identified the issue. A fix might be out within a couple of days.

If you are impacted, please subscribe to this issue to follow along.

@connorjclark
Copy link
Collaborator

Issue should be resolved as of ~2 hours ago. Can you confirm?

@privatenumber
Copy link

privatenumber commented Mar 12, 2021

@connorjclark You closed #12210 as a duplicate, but the problem still persists for me. Will post details there.

FYI, this issue seems to be reporting the problem in Lighthouse, but my issue only happens in PSI (works fine via Lighthouse CLI v7.2.0 and via Chrome browser dev tools).

@connorjclark connorjclark changed the title Lighthouse ignoring all objects using http/1.1 since Mar 3 PSI ignoring all objects using http/1.1 since Mar 3 Mar 12, 2021
@connorjclark
Copy link
Collaborator

connorjclark commented Mar 12, 2021

@privatenumber I looked into the issue for this URL this morning, but didn't get anywhere useful because it seems the behavior is flaky. It was failing all morning, but more recently it always works. So perhaps it's been resolved somehow. (EDIT: nope, I get failures now again. so it's flaky)

Some internal details lead me to believe that h2 specifically isn't the cause of this, so we'll close this issue (eventually, going to give some more time for others to comment); and if the issue on the URL you provided persists we'll re-open the other issue.

FYI ...

This issue is tracking behavior in PSI, not Lighthouse CLI or DevTools.

@connorjclark connorjclark added the PSI/LR PageSpeed Insights and Lightrider label Mar 12, 2021
@connorjclark
Copy link
Collaborator

We pushed a fix just now– @tferik, @privatenumber can you confirm?

@privatenumber
Copy link

Working consistently as of yesterday: #12210

Thank you @connorjclark !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 pending-close PSI/LR PageSpeed Insights and Lightrider
Projects
None yet
Development

No branches or pull requests

4 participants