Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend app returns only 200 code even an error happens when doing a transaction. #2144

Open
amandakarina opened this issue Jun 26, 2024 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@amandakarina
Copy link

amandakarina commented Jun 26, 2024

Describe the bug

When creating an E2E tests , when sending an invalid value or if some service is out, we still receive code 200.

To Reproduce

  1. Create a POST request to service payment or deposit with an invalid value (-1000, for example)
  2. The response will be 200 ok code even a error message is logged.
  3. Because of redirect to home, even when we add error code on redirect, home does not propagate the error.

Logs

The frontend app will log the error but is does not return the code.

Screenshots

Environment

Additional context

This error was found when adding an E2E tests on terraform-google-enterprise-application repo. It was workarounded checking the HTML return of home.

Exposure

Persistent.

@bourgeoisor bourgeoisor added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants