Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test(s): TestAccDataflowJob* #18074

Open
melinath opened this issue May 9, 2024 · 4 comments · May be fixed by GoogleCloudPlatform/magic-modules#12798
Open

Failing test(s): TestAccDataflowJob* #18074

melinath opened this issue May 9, 2024 · 4 comments · May be fixed by GoogleCloudPlatform/magic-modules#12798
Assignees
@shuyama1
Labels
forward/linked service/dataflow size/s test-failure test-failure-100 100% fail rate
Milestone
Oct 2024 Test Bur...

Comments

@melinath
Copy link
Collaborator

melinath commented May 9, 2024 •
edited
Loading

Impacted tests

  • TestAccDataflowJob_basic
  • TestAccDataflowJob_withProviderDefaultLabels
  • TestAccDataflowJob_withKmsKey
  • TestAccDataflowJobSkipWait_basic

Affected Resource(s)

  • google_dataflow_job

Failure rates

  • 100% since 2024-03-20

Message(s)

vcr_utils.go:152: Step 1/2 error: Check failed: Check 1/1 error: could not confirm Dataflow Job "2024-05-09_00_30_15-8505904879367105719" exists: googleapi: Error 404: (46a5a60f263a7f99): Information about job 2024-05-09_00_30_15-8505904879367105719 could not be found in our system. Please double check that the API being used is projects.locations.jobs.get (https://cloud.google.com/dataflow/docs/reference/rest/v1b3/projects.locations.jobs/get). If the API being used is projects.locations.jobs.get, please double check the id (2024-05-09_00_30_15-8505904879367105719) is correct. If it is please contact customer support., notFound

 Error: Cannot import non-existent remote object
        While attempting to import an existing object to
        "google_dataflow_job.big_data", the provider detected that no object exists
        with the given id. Only pre-existing objects can be imported; check that the
        id is correct and that it is associated with the provider's configured region
        or endpoint, or use "terraform apply" to create a new remote object for this
        resource.

Nightly build test history

b/339718340
@github-actions github-actions bot added forward/review In review; remove label to forward service/dataflow labels May 9, 2024
@melinath melinath removed the forward/review In review; remove label to forward label May 9, 2024
@melinath
Copy link
Collaborator Author

melinath commented May 9, 2024

@damondouglas FYI

@melinath melinath changed the title Failing test(s): TestAccDataflowJob_basic Failing test(s): TestAccDataflowJob* May 9, 2024
@rileykarson rileykarson added this to the Goals milestone May 28, 2024
@shuyama1
Copy link
Collaborator

shuyama1 commented Nov 5, 2024

I did a quick investigation on these failures, I believe the issue is we're not able to create zonal resource but always regional resource even if "zone" is explicitly set in this case.

terraform-provider-google/google/services/dataflow/resource_dataflow_job.go

Lines 571 to 574 in b528f87

if region == "" {
return config.NewDataflowClient(userAgent).Projects.Templates.Create(project, request).Do()
}
return config.NewDataflowClient(userAgent).Projects.Locations.Templates.Create(project, region, request).Do()

terraform-provider-google/google/tpgresource/field_helpers.go

Line 466 in b528f87

return GetRegionFromZone(zone), nil

@damondouglas
Copy link

Now that I figured out how to troubleshoot these tests, I'll apply this method to the all the Dataflow-related tests and apply PRs fixes where relevant.

@damondouglas damondouglas linked a pull request Jan 18, 2025 that will close this issue
Open
@damondouglas
Copy link

Created GoogleCloudPlatform/magic-modules#12798

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shuyama1 shuyama1

Labels
forward/linked service/dataflow size/s test-failure test-failure-100 100% fail rate
Projects
None yet
Milestone
Oct 2024 Test Burndown
Development

Successfully merging a pull request may close this issue.

Fix failing TestAccDataflowJob tests. damondouglas/magic-modules
5 participants
@melinath @damondouglas @rileykarson @modular-magician @shuyama1