Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve substitution of variables in Kustomize components #2491

Open
bourgeoisor opened this issue Apr 17, 2024 · 0 comments
Open

Improve substitution of variables in Kustomize components #2491

bourgeoisor opened this issue Apr 17, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@bourgeoisor
Copy link
Member

Kustomize components (like alloydb and shopping-assistant) rely on some dynamic variables to be substituted. We currently rely on sed but that is not best practices. Additionally, sed behaviour can change depending on the user's OS.

Let's thinking about how we can improve this flow.

Example: https://github.com/GoogleCloudPlatform/microservices-demo/blob/main/kustomize/components/shopping-assistant/scripts/1_deploy_alloydb_infra.sh#L91-L112
@bourgeoisor bourgeoisor added type: cleanup An internal cleanup or hygiene concern. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bourgeoisor