Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov flakes on datapointcache.go #790

Open
damemi opened this issue Jan 3, 2024 · 2 comments
Open

Codecov flakes on datapointcache.go #790

damemi opened this issue Jan 3, 2024 · 2 comments
Labels
bug Something isn't working priority: p3

Comments

@damemi
Copy link
Contributor

damemi commented Jan 3, 2024

exporter/collector/internal/datapointstorage/datapointcache.go regularly causes PR codecov checks to flake as an indirect change. See https://app.codecov.io/gh/GoogleCloudPlatform/opentelemetry-operations-go/pulls

It looks like it is usually an issue with unchecked for loops in the gc function at

func (c *Cache) gc(shutdown <-chan struct{}, tickerCh <-chan time.Time) bool {

Creating this issue to track a fix or reference when approving flaking PRs

@aabmass
Copy link
Contributor

aabmass commented Jan 29, 2024

Discussed in triage, it seems like the real issue is the tests are not deterministic/hermetic. Low priority but we would like to get this fixed.

@aabmass aabmass added bug Something isn't working priority: p2 labels Jan 29, 2024
@punya
Copy link
Contributor

punya commented May 20, 2024

Reducing priority because (anecdotally) this hasn't come up much in recent runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: p3
Projects
None yet
Development

No branches or pull requests

3 participants