Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

Eliminate per-IAM-resource Merge functions #244

Open
melinath opened this issue Jun 29, 2021 · 1 comment
Open

Eliminate per-IAM-resource Merge functions #244

melinath opened this issue Jun 29, 2021 · 1 comment
Labels

Comments

@melinath
Copy link
Member

The Merge functions are always the same (and will always be the same for standard IAM resources). We should create a standard set of functions and eliminate the individual functions in each IAM resource conversion file.

# before
"google_bigquery_table_iam_binding": {
	{
		Convert:           GetBigQueryTableIamBindingCaiObject,
		MergeCreateUpdate: MergeBigQueryTableIamBinding,
		MergeDelete:       MergeBigQueryTableIamBindingDelete,
		Fetch:             FetchBigQueryTableIamPolicy,
	},
},

# after
"google_bigquery_table_iam_binding": {
	{
		Convert:           GetBigQueryTableIamBindingCaiObject,
		MergeCreateUpdate: MergeIamBinding,
		MergeDelete:       MergeIamBindingDelete,
		Fetch:             FetchBigQueryTableIamPolicy,
	},
},

For now we want to keep those fields in the mappers because we may need the flexibility in the future.

@melinath melinath added good first issue Good for newcomers tech debt labels Jun 29, 2021
@marktru
Copy link

marktru commented Dec 23, 2021

Internal issue: b/211902200

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants