Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sourceImage's labels should not be included in cache key #3342

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mzihlmann
Copy link

Fixes #3088
relates to !3338

Description

Currently the CreatedAt timestamp, image labels (and all other metadata) is included into kaniko's cache key, this means that if a new image is created with the exact same layers but different labels, it invalidates caches in all builds that use it as a base.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

  • kaniko cache learned to ignore labels in base images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--label causes cache invalidation in later stages
1 participant