Serialize tags as list #78
Conversation
tasklib/serializing.py
Outdated
| @@ -173,12 +173,14 @@ def deserialize_annotations(self, data): | |||
| return [TaskAnnotation(self, d) for d in data] if data else [] | |||
|
|
|||
| def serialize_tags(self, tags): | |||
| return ','.join(tags) if tags else '' | |||
| return list(tags) | |||
There was a problem hiding this comment.
The point of the serialization is to turn the object into a string representation, so this should be cast as a string.
That said, I am not yet entirely convinced this would work (i.e. with older versions of the TW). Maybe we can revive travis @robgolding ?
There was a problem hiding this comment.
I have been using this branch for weeks with the latest taskwarrior version. The only issue that arose (#83) was due to me not knowing python well and is now fixed.
Why would we need to support old taskwarrior versions with new releases?
Reviving travis sounds good anyways though.
|
As detailed in tbabej/taskpirate#19 and #77 the bug this PR is fixing is biting people by silently corrupting data. What can we do to help land this fix? |
Fixes #77