Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames should be unique #19

Open
mgifford opened this issue Jan 25, 2021 · 5 comments
Open

Filenames should be unique #19

mgifford opened this issue Jan 25, 2021 · 5 comments

Comments

@mgifford
Copy link

The reports should have URL & date hard coded into the names. So say 18f.gov-25012020-report.html & 18f.gov-25012020-compiledResult.json

This would make it easier to track.

@brianteeman
Copy link
Contributor

As each scan is in its own named folder with stename and date I assume that this request has been addressed elsewhere since this issue was raised

@mgifford
Copy link
Author

I think the package has evolved a lot since 2021 @brianteeman

I also don't think that the maintainers engage much with the issue queue unfortunately.

Good seeing you here!

@brianteeman
Copy link
Contributor

@mgifford came back to visit it and saw a lot changes. Not sure about the privacy changes and tracking on reports though so might have to fork it

@mgifford
Copy link
Author

Let me know what you do with it. I forked it a while back https://github.com/civicactions/purple-hats 

Didn't have enough JS to maintain it. I did have the ability to create something that created better reports though. Least in my use case.

@brianteeman
Copy link
Contributor

yes I remember your fork - but looking here it has been developed much more than when I last looked at yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants