Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(portal): the display of long_text for Interactive should be refactored to varchar(max_length) #649

Open
longbinlai opened this issue Dec 24, 2024 · 1 comment
Assignees
Labels
Enhancement Modeling issues related to create schema pages

Comments

@longbinlai
Copy link
Collaborator

For now, portal (for both data importing and model description),
Screenshot 2024-12-24 at 11 08 46

There are three types of data that we aim to support for DT_STRING :

  • CHAR (fixed_length): which is a fixed-length char array
  • VARCHAR (length): which is a char array where each item can have variant length but cannot exceed the given length
  • LONG_TEXT: which is an array of strings of arbitrary length

Now Interactive only supports VARCHAR(length), but portal uses DT_STRING, which has the semantic of LONG_TEXT, we must explictly tell user that it is VARCHAR, and allow them to specify the length upperbound, knowing that string exceeding that length will be cut off.

@pomelo-nwu pomelo-nwu added Enhancement Modeling issues related to create schema pages labels Dec 24, 2024
@longbinlai
Copy link
Collaborator Author

Also check this PR: alibaba/GraphScope#4367, for tracking the progress of type alignments on the backend engines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Modeling issues related to create schema pages
Projects
None yet
Development

No branches or pull requests

2 participants