Make the Select tool avoid updating hints just when clicking but not dragging #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tool implementations accordingly, use tool_data in select_tool update_hints function as well as add a UpdateHints response when the pointer moves after the change from DragStart to Dragging state
|
Hi, @Keavon please review. |
|
Will try to do within the next few days. Working to catch up on reviews. |
Keavon
approved these changes
Feb 5, 2025
Keavon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves https://discord.com/channels/731730685944922173/881073965047636018/1334123140842000386
Make Fsm
update_hintsfunction borrowtool_dataand update individual tool implementations accordingly, usetool_datain select_toolupdate_hintsfunction as well as add aUpdateHintsresponse when the pointer moves after the change from DragStart to Dragging state.