fix: remove --deep #188
fix: remove --deep #188
Conversation
github-actions
bot
added
gui
|
If you could test this PR build once it finishes to see if anything is broken that'd be appreciated; I don't own a mac. |
Everything is working the same as before for me. All still works |
|
It also builds in nixpkgs. That was my success marker. Just previously it didn't build on MacOS 13.0+ because of the removal of --deep from codesign |
|
Working well. Seems to be more stable than the current version- Been playing Echoes of Wisdom for a couple hours now without a crash |
|
Hello @GreemDev , Since this has been checked in I can no longer create and sign the app bundle locally. I am using the following to build, create, and sign the app bundle: ./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release I get this error when it attempts to sign: /Volumes/MACBOOK/ROMS/NSW/Ryujinx/GitHub/Ryujinx/distribution/macos/temp/output_x64/Ryujinx.app: code object is not signed at all if I reinstate the "--deep" parameter it starts working again, I assume this is because the "/libglfw.3.dylib" file and other library files need to be re-signed and it is no longer being signed because of the missing "--deep" parameter, do I need to do something differently now to get the app bundle to be signed successfully? Note that if I add an extra line before this line in the "create_app_bundle.sh" script: codesign --entitlements "$ENTITLEMENTS_FILE_PATH" -f -s - "$APP_BUNDLE_DIRECTORY" Of: find "$APP_BUNDLE_DIRECTORY" -name "*.dylib" -exec codesign -f -s - {} ; Forcing these libraries to be code re-signed, the issue also goes away, maybe we should add this line in? REPRODUCTION
./distribution/macos/create_macos_build_ava.sh ./ ./distribution/macos/temp ./distribution/macos/output ./distribution/macos/entitlements.xml 1.0.0 0 Release
Thank You. |
|
does it fix crashing on rasberry pi 5? |
|
@amurgshere please make a new issue for this. |
Significant changes include LDN functionality from @Vudjun (no more separate build!) and an XCI trimmer from @amurgshere. Merged PRs in this release (in the order they were merged): #183, #150, #105, #160, #188, #98, #158, #13, #216, #73, #217, #122, #228, #65, #226, #236, #247, #243, #249, #242, #260, #273, #272, #262, #259, #241 ## Versioning: There now exists "stable" (release branch) and ["canary" (master branch)](https://github.com/GreemDev/Ryujinx-Canary/releases) versions. Instead of everyone using the same emulator, getting updates for every code change, you now *opt-in* to the more frequent updates by using the Canary version. Use stable and you'll get about an update a week, but that update will be MUCH more significant as it's the entire previous week's changes & PR merges. ## LDN LDN functionality is now merged! Use [this](https://github.com/GreemDev/Ryujinx/wiki/Multiplayer%E2%80%90(LDN%E2%80%90Local%E2%80%90Wireless)%E2%80%90Guide) to get started. Please note that LDN is only for local wireless; **this is not a Nintendo Switch Online emulation feature**. ## UI - Added an XCI trimmer (#105). - You can use this feature to trim dead bytes & the embedded firmware out of your dumped XCIs, to make them smaller. - If you right-click an XCI and the trim button it is greyed out, that means your XCI is already as small as possible. - Fix for fullscreen not being really fullscreen (#150) - Fix window sizing calculations when Show Title Bar is enabled (#247) - The "Install/Uninstall file types" buttons will be enabled/disabled depending on which one you contextually need; install will be clickable when they aren't installed, and vice versa. - Fix for showing default config screen when swapping players in controller settings (#122) - Command-line argument to prevent update checking `--hide-updates` (#272) - # RPC: - Added a LOT of game images to Discord RPC. - Play time will now show the time unit hours at a maximum. ## Localization - Update outdated/incorrect & added missing translations for zh-TW (#158) - Add many missing locale strings to all languages (#160) - Update & improve Korean translation (#226) - Minor fixes & add missing translations to Spanish translation (#242) ## Headless - Added `ignore-controller-applet` as an option you can configure via headless command-line options. ## Graphics Backend - ### Vulkan - fix divide-by-zero when recovering from missed draw (#235) - fixes crash in 'Baldo: The Guardian Owls' opening cutscene ## Horizon - fix crash that occurs when launching an NSP forwarder generated by Nro2Nsp (#237) # Nerd Zone Slightly more technical information. If you don't understand what's under here, no worry. - Updater now uses the release's Tag Name instead of its Name for version checking. - Baked in value change logging into ReactiveObject. - Split ConfigurationState into 3, smaller partial classes of the same name. - Specify if the current version is Canary in the version log line --------- Co-authored-by: James Duarte <[email protected]> Co-authored-by: Luke Warner <[email protected]> Co-authored-by: TheToid <[email protected]> Co-authored-by: GabCoolGuy <[email protected]> Co-authored-by: Kekschen <[email protected]> Co-authored-by: WilliamWsyHK <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jacobwasbeast <[email protected]> Co-authored-by: Piplup <[email protected]> Co-authored-by: Vladimir Sokolov <[email protected]> Co-authored-by: Jonas Henriksson <[email protected]> Co-authored-by: Vudjun <[email protected]> Co-authored-by: extherian <[email protected]> Co-authored-by: Hack茶ん <[email protected]> Co-authored-by: EmulationEnjoyer <[email protected]> Co-authored-by: Nicola <[email protected]> Co-authored-by: jzumaran <[email protected]> Co-authored-by: Pitchoune <[email protected]> Co-authored-by: Narugakuruga <[email protected]>
Resolves #182
See issue for more info.