Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No set boundary conditions #2

Open
vidstige opened this issue Feb 28, 2021 · 2 comments
Open

No set boundary conditions #2

vidstige opened this issue Feb 28, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@vidstige
Copy link

The original paper uses a nifty set_bnd function that was very easy to extend that allowed boundary conditions to be set, e.g. adding walls to the box, preventing densities (and velocities) from escaping. Furthermore, interesting effects could be achieved by adding internal boundaries of various shapes. In this very beautiful and awesome re-implementation of the paper the boundary conditions is not possible to specify. After reading the code, it seems very doable. Perhaps you prefer to have it completely outside the Fluid class? 🤔

@GregTJ
Copy link
Owner

GregTJ commented Mar 3, 2021

I'm (slowly) working on a total rewrite of this fluid simulation using a different method of computing the Helmholtz decomposition that allows for much greater flexibility in terms of boundary conditions, as well as a significant prospective boost in performance. See this video and associated whitepaper for details. As such, I don't really have time to dedicate to improving this branch of the project.

However, if you would like to implement any feature ideas I would be happy to look them over and merge them with this repo. Note that in the rewrite I'm using slightly different indexing conventions, meaning that changes to the current codebase will be incompatible with the rewrite. The biggest changes I'm making in that respect are placing the index representing vector components first in each ndarray instead of last as it is currently, and avoiding any flattened arrays. Thank you for your interest in the project!

@vidstige
Copy link
Author

vidstige commented Mar 3, 2021

Thanks for the update! Very exiting stuff indeed. If I find a way to merge back some changes, I definitely will. Again, thanks for this very awesome, fast and cute python program.

@GregTJ GregTJ added the enhancement New feature or request label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants