Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipenet rewrite #1945

Open
wants to merge 70 commits into
base: 1.20.1
Choose a base branch
from
Open

pipenet rewrite #1945

wants to merge 70 commits into from

Conversation

screret
Copy link
Member

@screret screret commented Sep 11, 2024

What

port GregTechCEu/GregTech#2304

Implementation Details

mmm pipes

Outcome

I assume some pipe-related bugs will be fixed, but won't be marking them here until further notice.

@screret screret requested review from a team as code owners September 11, 2024 18:12
@YoungOnionMC YoungOnionMC marked this pull request as draft September 11, 2024 18:49
@screret screret added the type: refactor Suggestion to refactor a section of code label Sep 26, 2024
@screret screret marked this pull request as ready for review September 27, 2024 11:15
@screret screret mentioned this pull request Oct 1, 2024
Merged
krossgg
krossgg approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@krossgg krossgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the datafixers nor the actual graph logic.
Other changes look fine to me from my semi-cursory review.

screret added 20 commits October 1, 2024 14:18
@screret
start on graph pipenet port :) (very much WIP, doesn't launch at all,…
45847f1 
… etc.)
@screret
stuff
a42e55f
@screret
holy hell
2ada98e
@screret
pipenets
5a6d384
@screret
stuff
841d519
@screret
holy errors, batman!
e8215ad
@screret
fix conveyor cover build errors, spotless
811a443
@screret
duct pipes
d9a2495
@screret
fluid pipe properties
e41c4a8
@screret
WHAT THE FUCK THE COMPILE ERRORS STOPPED COMING
a5c6415 
now for the runtime ones :)
@screret
rendering does nnnnot work just yet, placing a block crashes because …
a26d800 
…shadow is being a lil bitch
@screret
it works now yay
6c0de35
@screret
actually fix #1650
918fcad
@screret
allow blocks without block entities to do grid highlights as well
f55c36b
@screret
fix world pipe nets not having their level set correctly
ae1b610
@screret
clean up JAVD compat because it annoyed me
7bd7a6e
@screret
everything works, except:
70cb63a 
- placing machines on cables connecting
- placing cables on machines connecting
- fancy glow effect on cable melt
@screret
render works now
eedb538
@screret
new model logic port
18808f5
@screret
it works :yippee:
c965fe0
screret added 19 commits October 1, 2024 14:18
@screret
port lots of changes
7f2011f
@screret
fix gradle + spotless + datagen
8fdf4aa
@screret
disable gradle-home-cache-cleanup so that action works again
6c7ecd0
@screret
fix errors, spotless, datagen refresh
388b11a
@screret
attempt number 1 at fixing the github build
b0acd14
@screret
number 2
6d48dcc
@screret
attempt number 3
bfca36f
@screret
fix laser redirector pipe model
80d63a2
@screret
attempt 4
bf838ae
@screret
attempt 5
0510507
@screret
yippee it works
635d512
@screret
fix pipe structures not actually being registered
30e68ad
@screret
fix laser bender grid overlay not working correctly
0ec799f
@screret
fix laser bender texture showing through because the texture wasn't f…
69dee7b 
…ull block
@screret
try to fix shadow using dependencies from runtimeClasspath
80bae58
@screret
fix moving when a server closes crashing the client
3a8c495
@screret
fix server
1e6a6b0
@screret
fix portable scanner using the wrong method for getting block tooltip…
8435c54 
…s, which broke it for cable/material blocks
@screret
sbobldes
656d7c3
@screret screret force-pushed the sc/pipenet-rewrite branch from dc2746a to 656d7c3 Compare October 1, 2024 11:19
@screret screret added the Do Not Merge DO NOT MERGE THIS PR YET! label Oct 2, 2024
@screret
Copy link
Member Author

screret commented Oct 2, 2024

result: way more laggy than the old implementation. needs more work to make stable.

@a-a-GiTHuB-a-a
Copy link
Contributor

any ideas for optimization at all…?

@RainPumpkin
Copy link

it's being worked on in 1.12 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krossgg krossgg krossgg approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge DO NOT MERGE THIS PR YET! type: refactor Suggestion to refactor a section of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@screret @a-a-GiTHuB-a-a @RainPumpkin @krossgg