apply negative potion effects when holding filled containers #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Applies negative potion effects to the player when holding filled Drums, Super Tanks, Crates, and Super Chests. Adds an API to apply these effects across a wider set of items if desired in the future, as well as a system to allow specifying armor which counts towards negating the effects. Wearing 4 pieces of negating armor is required to negate the effects, and no fewer.
Outcome
Applies negative potion effects to players carrying filed containers.
Additional Information
Because this applies to drums, they cannot be considered directly superior to fluid cells anymore. Players will want to switch to cells for manual fluid handling.