From 86bd1d4d2c3c7ea5805a4994ff4859433683abe2 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 14:14:01 +0800 Subject: [PATCH 1/8] add unit test for bare-metal Signed-off-by: sh2 --- go.mod | 2 +- go.sum | 8 -- .../baremetal/test_data/invalid_artifact.yaml | 21 ++++ .../test_data/invalid_hostname_port.yaml | 19 ++++ .../baremetal/test_data/invalid_replicas.yaml | 19 ++++ .../baremetal/test_data/valid_config.yaml | 19 ++++ pkg/deployer/baremetal/validate_test.go | 95 +++++++++++++++++++ 7 files changed, 174 insertions(+), 9 deletions(-) create mode 100644 pkg/deployer/baremetal/test_data/invalid_artifact.yaml create mode 100644 pkg/deployer/baremetal/test_data/invalid_hostname_port.yaml create mode 100644 pkg/deployer/baremetal/test_data/invalid_replicas.yaml create mode 100644 pkg/deployer/baremetal/test_data/valid_config.yaml create mode 100644 pkg/deployer/baremetal/validate_test.go diff --git a/go.mod b/go.mod index 57c131b3..31e0a325 100644 --- a/go.mod +++ b/go.mod @@ -8,6 +8,7 @@ require ( github.com/Masterminds/semver/v3 v3.2.1 github.com/briandowns/spinner v1.19.0 github.com/fatih/color v1.13.0 + github.com/go-pg/pg/v10 v10.11.1 github.com/go-playground/validator/v10 v10.14.1 github.com/go-sql-driver/mysql v1.6.0 github.com/google/go-cmp v0.5.9 @@ -62,7 +63,6 @@ require ( github.com/go-openapi/jsonpointer v0.19.5 // indirect github.com/go-openapi/jsonreference v0.20.0 // indirect github.com/go-openapi/swag v0.19.14 // indirect - github.com/go-pg/pg/v10 v10.11.1 // indirect github.com/go-pg/zerochecker v0.2.0 // indirect github.com/go-playground/locales v0.14.1 // indirect github.com/go-playground/universal-translator v0.18.1 // indirect diff --git a/go.sum b/go.sum index 6c41e732..c3aebe10 100644 --- a/go.sum +++ b/go.sum @@ -661,8 +661,6 @@ golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a/go.mod h1:LzIPMQfyMNhhGPh golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc= golang.org/x/crypto v0.1.0/go.mod h1:RecgLatLF4+eUMCP1PoPZQb+cVrJcOPbHkTkbkB9sbw= golang.org/x/crypto v0.3.0/go.mod h1:hebNnKkNXi2UzZN1eVRvBB7co0a+JxK6XbPiWVs/3J4= -golang.org/x/crypto v0.7.0 h1:AvwMYaRytfdeVt3u6mLaxYtErKYjxA2OXjJ1HHq6t3A= -golang.org/x/crypto v0.7.0/go.mod h1:pYwdfH91IfpZVANVyUOhSIPZaFoJGxTFbZhFTx+dXZU= golang.org/x/crypto v0.12.0 h1:tFM/ta59kqch6LlvYnPa0yx5a83cL2nHflFhYKvv9Yk= golang.org/x/crypto v0.12.0/go.mod h1:NF0Gs7EO5K4qLn+Ylc+fih8BSTeIjAP05siRnAh98yw= golang.org/x/exp v0.0.0-20190121172915-509febef88a4/go.mod h1:CJ0aWSM057203Lf6IL+f9T1iT9GByDxfZKAQTCR3kQA= @@ -853,16 +851,12 @@ golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f/go.mod h1:oPkhp1MJrh7nUepCBc golang.org/x/sys v0.0.0-20220811171246-fbc7d0a398ab/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.1.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.2.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= -golang.org/x/sys v0.8.0 h1:EBmGv8NaZBZTWvrbjNoL6HVt+IVy3QDQpJs7VRIw3tU= -golang.org/x/sys v0.8.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/sys v0.11.0 h1:eG7RXZHdqOJ1i+0lgLgCpSXAp6M3LYlAo6osgSi0xOM= golang.org/x/sys v0.11.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg= golang.org/x/term v0.0.0-20201126162022-7de9c90e9dd1/go.mod h1:bj7SfCRtBDWHUb9snDiAeCFNEtKQo2Wmx5Cou7ajbmo= golang.org/x/term v0.0.0-20210927222741-03fcf44c2211/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= golang.org/x/term v0.1.0/go.mod h1:jbD1KX2456YbFQfuXm/mYQcufACuNUgVhRMnK/tPxf8= golang.org/x/term v0.2.0/go.mod h1:TVmDHMZPmdnySmBfhjOoOdhjzdE1h4u1VwSiw2l1Nuc= -golang.org/x/term v0.8.0 h1:n5xxQn2i3PC0yLAbjTpNT85q/Kgzcr2gIoX9OrJUols= -golang.org/x/term v0.8.0/go.mod h1:xPskH00ivmX89bAKVGSKKtLOWNx2+17Eiy94tnKShWo= golang.org/x/term v0.11.0 h1:F9tnn/DA/Im8nCwm+fX+1/eBwi4qFjRT++MhtVC4ZX0= golang.org/x/term v0.11.0/go.mod h1:zC9APTIj3jG3FdV/Ons+XE1riIZXG4aZ4GTHiPZJPIU= golang.org/x/text v0.0.0-20170915032832-14c0d48ead0c/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= @@ -875,8 +869,6 @@ golang.org/x/text v0.3.5/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ= golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ= golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8= -golang.org/x/text v0.9.0 h1:2sjJmO8cDvYveuX97RDLsxlyUxLl+GHoLxBiRdHllBE= -golang.org/x/text v0.9.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8= golang.org/x/text v0.12.0 h1:k+n5B8goJNdU7hSvEtMUz3d1Q6D/XW4COJSJR6fN0mc= golang.org/x/text v0.12.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE= golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ= diff --git a/pkg/deployer/baremetal/test_data/invalid_artifact.yaml b/pkg/deployer/baremetal/test_data/invalid_artifact.yaml new file mode 100644 index 00000000..cf8c53ad --- /dev/null +++ b/pkg/deployer/baremetal/test_data/invalid_artifact.yaml @@ -0,0 +1,21 @@ +cluster: + name: mycluster # name of the cluster + artifact: + version: v0.2.0-nightly-20230403 + frontend: + replicas: 1 + datanode: + replicas: 3 + rpcAddr: 0.0.0.0:14100 + mysqlAddr: 0.0.0.0:14200 + httpAddr: 0.0.0.0:14300 + meta: + storeAddr: 127.0.0.1:2379 + serverAddr: 0.0.0.0:3002 + httpAddr: 0.0.0.0:14001 + +etcd: + artifact: # invalid artifact + version: + local: + diff --git a/pkg/deployer/baremetal/test_data/invalid_hostname_port.yaml b/pkg/deployer/baremetal/test_data/invalid_hostname_port.yaml new file mode 100644 index 00000000..cc0e4522 --- /dev/null +++ b/pkg/deployer/baremetal/test_data/invalid_hostname_port.yaml @@ -0,0 +1,19 @@ +cluster: + name: mycluster # name of the cluster + artifact: + version: v0.2.0-nightly-20230403 + frontend: + replicas: 1 + datanode: + replicas: 3 + rpcAddr: 0.0.0.0:14100 + mysqlAddr: 0.0.0.0:14200 + httpAddr: 0.0.0.0:1438000 # invalid port + meta: + storeAddr: 127.0.0.1:2379 + serverAddr: 6870.0.0.0:3243002 # invalid hostname and port + httpAddr: 0.0.0.0:14001 + +etcd: + artifact: + version: v3.5.7 diff --git a/pkg/deployer/baremetal/test_data/invalid_replicas.yaml b/pkg/deployer/baremetal/test_data/invalid_replicas.yaml new file mode 100644 index 00000000..e64f881b --- /dev/null +++ b/pkg/deployer/baremetal/test_data/invalid_replicas.yaml @@ -0,0 +1,19 @@ +cluster: + name: mycluster # name of the cluster + artifact: + version: v0.2.0-nightly-20230403 + frontend: + replicas: 0 # invalid replicas + datanode: + replicas: -3 # invalid replicas + rpcAddr: 0.0.0.0:14100 + mysqlAddr: 0.0.0.0:14200 + httpAddr: 0.0.0.0:14300 + meta: + storeAddr: 127.0.0.1:2379 + serverAddr: 0.0.0.0:3002 + httpAddr: 0.0.0.0:14001 + +etcd: + artifact: + version: v3.5.7 diff --git a/pkg/deployer/baremetal/test_data/valid_config.yaml b/pkg/deployer/baremetal/test_data/valid_config.yaml new file mode 100644 index 00000000..04d8b6eb --- /dev/null +++ b/pkg/deployer/baremetal/test_data/valid_config.yaml @@ -0,0 +1,19 @@ +cluster: + name: mycluster # name of the cluster + artifact: + version: v0.2.0-nightly-20230403 + frontend: + replicas: 1 + datanode: + replicas: 3 + rpcAddr: 0.0.0.0:14100 + mysqlAddr: 0.0.0.0:14200 + httpAddr: 0.0.0.0:14300 + meta: + storeAddr: 127.0.0.1:2379 + serverAddr: 0.0.0.0:3002 + httpAddr: 0.0.0.0:14001 + +etcd: + artifact: + version: v3.5.7 diff --git a/pkg/deployer/baremetal/validate_test.go b/pkg/deployer/baremetal/validate_test.go new file mode 100644 index 00000000..5d03ecc3 --- /dev/null +++ b/pkg/deployer/baremetal/validate_test.go @@ -0,0 +1,95 @@ +// Copyright 2023 Greptime Team +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package baremetal + +import ( + "fmt" + "os" + "testing" + + "github.com/stretchr/testify/assert" + "gopkg.in/yaml.v3" + + "github.com/GreptimeTeam/gtctl/pkg/deployer/baremetal/config" +) + +func TestValidateConfig(t *testing.T) { + testCases := []struct { + name string + expect bool + errKey []string + }{ + { + name: "valid_config", + expect: true, + }, + { + name: "invalid_hostname_port", + expect: false, + errKey: []string{ + "Config.Cluster.MetaSrv.ServerAddr", + "Config.Cluster.Datanode.HTTPAddr", + }, + }, + { + name: "invalid_replicas", + expect: false, + errKey: []string{ + "Config.Cluster.Frontend.Replicas", + "Config.Cluster.Datanode.Replicas", + }, + }, + { + name: "invalid_artifact", + expect: false, + errKey: []string{ + "Config.Etcd.Artifact.Artifact", + }, + }, + } + + for _, tc := range testCases { + t.Run(tc.name, func(t *testing.T) { + t.Parallel() + + var actual config.Config + if err := loadConfig(fmt.Sprintf("test_data/%s.yaml", tc.name), &actual); err != nil { + t.Errorf("error while loading %s file: %v", tc.name, err) + } + + err := ValidateConfig(&actual) + if tc.expect { + assert.NoError(t, err) + } else { + assert.Error(t, err) + for _, key := range tc.errKey { + assert.Contains(t, err.Error(), key) + } + } + }) + } +} + +func loadConfig(path string, ret *config.Config) error { + configs, err := os.ReadFile(path) + if err != nil { + return err + } + + if err = yaml.Unmarshal(configs, ret); err != nil { + return err + } + return nil +} From f21296807ae272b75fb43f62c10799ac9a188fd8 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 14:23:06 +0800 Subject: [PATCH 2/8] separate ci build into linter, ut and e2e Signed-off-by: sh2 --- .github/workflows/ci.yaml | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 7aad5d7d..acac2001 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -11,7 +11,7 @@ jobs: uses: actions/checkout@v3 - name: Check spelling with custom config file uses: crate-ci/typos@v1.14.8 - build: + linter: runs-on: ubuntu-latest steps: - name: Checkout sources @@ -27,11 +27,17 @@ jobs: with: version: v1.50.0 args: --timeout 10m0s - + unit-test: + runs-on: ubuntu-latest + needs: [ linter ] + steps: - name: unit test run: | make test - + e2e-test: + runs-on: ubuntu-latest + needs: [ linter ] + steps: - name: e2e test of basic cluster run: | make e2e From 2a844d97a95d9af077f519b6faecae8f7d400bec Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 14:31:33 +0800 Subject: [PATCH 3/8] update ci Signed-off-by: sh2 --- .github/workflows/ci.yaml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index acac2001..07d068e7 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -12,6 +12,7 @@ jobs: - name: Check spelling with custom config file uses: crate-ci/typos@v1.14.8 linter: + name: Linter runs-on: ubuntu-latest steps: - name: Checkout sources @@ -28,16 +29,34 @@ jobs: version: v1.50.0 args: --timeout 10m0s unit-test: + name: Unit Test runs-on: ubuntu-latest needs: [ linter ] steps: + - name: Checkout sources + uses: actions/checkout@v3 + + - name: Setup Go + uses: actions/setup-go@v3 + with: + go-version: "1.18.4" + - name: unit test run: | make test e2e-test: + name: e2e Test runs-on: ubuntu-latest needs: [ linter ] steps: + - name: Checkout sources + uses: actions/checkout@v3 + + - name: Setup Go + uses: actions/setup-go@v3 + with: + go-version: "1.18.4" + - name: e2e test of basic cluster run: | make e2e From 77aa10e51f247076df417c62592d7b2ea45c8075 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 14:40:37 +0800 Subject: [PATCH 4/8] optimize ci name Signed-off-by: sh2 --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/license-checker.yaml | 2 +- .github/workflows/pr-title-checker.yaml | 3 ++- .github/workflows/release.yml | 4 ++-- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 07d068e7..ba430e56 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -4,7 +4,7 @@ on: [push, pull_request] jobs: typos-check: - name: Spell Check with Typos + name: spell-typos-check runs-on: ubuntu-latest steps: - name: Checkout Actions Repository @@ -12,7 +12,7 @@ jobs: - name: Check spelling with custom config file uses: crate-ci/typos@v1.14.8 linter: - name: Linter + name: linter runs-on: ubuntu-latest steps: - name: Checkout sources @@ -29,7 +29,7 @@ jobs: version: v1.50.0 args: --timeout 10m0s unit-test: - name: Unit Test + name: unit-test runs-on: ubuntu-latest needs: [ linter ] steps: @@ -45,7 +45,7 @@ jobs: run: | make test e2e-test: - name: e2e Test + name: e2e-test-kubernetes runs-on: ubuntu-latest needs: [ linter ] steps: diff --git a/.github/workflows/license-checker.yaml b/.github/workflows/license-checker.yaml index d5919b8b..cd61b88e 100644 --- a/.github/workflows/license-checker.yaml +++ b/.github/workflows/license-checker.yaml @@ -1,4 +1,4 @@ -name: License checker +name: License on: push: diff --git a/.github/workflows/pr-title-checker.yaml b/.github/workflows/pr-title-checker.yaml index 4d693783..86599071 100644 --- a/.github/workflows/pr-title-checker.yaml +++ b/.github/workflows/pr-title-checker.yaml @@ -1,9 +1,10 @@ -name: PR Title Checker +name: Title on: [pull_request] jobs: check: + name: pr-title-check runs-on: ubuntu-latest steps: - uses: thehanimo/pr-title-checker@v1.3.4 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 17042d1c..afe585c3 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -6,7 +6,7 @@ on: jobs: build: - name: Build binary + name: build-binary strategy: matrix: # The file format is gtctl-- @@ -65,7 +65,7 @@ jobs: path: bin/${{ matrix.file }}.sha256sum release: - name: Release artifacts + name: release-artifacts needs: [ build ] runs-on: ubuntu-latest steps: From 6a5e1da1b9e0244a82360baa852dab9554caecc6 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 15:07:10 +0800 Subject: [PATCH 5/8] add codecov in ci Signed-off-by: sh2 --- .github/workflows/ci.yaml | 17 +++++++++++------ .gitignore | 1 + Makefile | 4 ++++ pkg/deployer/baremetal/validate_test.go | 2 -- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ba430e56..3ebc3d50 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -29,9 +29,8 @@ jobs: version: v1.50.0 args: --timeout 10m0s unit-test: - name: unit-test + name: unit-test-coverage runs-on: ubuntu-latest - needs: [ linter ] steps: - name: Checkout sources uses: actions/checkout@v3 @@ -41,13 +40,19 @@ jobs: with: go-version: "1.18.4" - - name: unit test + - name: Unit test run: | - make test + make coverage + - name: Upload coverage to Codecov + uses: codecov/codecov-action@v3 + with: + fail_ci_if_error: true + files: ./coverage.xml + name: codecov-gtctl + verbose: true e2e-test: - name: e2e-test-kubernetes + name: e2e-test runs-on: ubuntu-latest - needs: [ linter ] steps: - name: Checkout sources uses: actions/checkout@v3 diff --git a/.gitignore b/.gitignore index 9f2ced17..ecc01db2 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ testbin/* .vscode .gtctl +coverage.xml diff --git a/Makefile b/Makefile index ddd596b8..c42e9e12 100644 --- a/Makefile +++ b/Makefile @@ -31,6 +31,10 @@ e2e: gtctl setup-e2e ## Run e2e. test: ## Run unit test. go test -timeout 1m -v ./pkg/... +.PHONY: coverage +coverage: ## Run unit test with coverage. + go test ./pkg/... -race -coverprofile=coverage.xml -covermode=atomic + .PHONY: fix-license-header fix-license-header: license-eye ## Fix license header. license-eye -c .licenserc.yaml header fix diff --git a/pkg/deployer/baremetal/validate_test.go b/pkg/deployer/baremetal/validate_test.go index 5d03ecc3..5a99288a 100644 --- a/pkg/deployer/baremetal/validate_test.go +++ b/pkg/deployer/baremetal/validate_test.go @@ -62,8 +62,6 @@ func TestValidateConfig(t *testing.T) { for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { - t.Parallel() - var actual config.Config if err := loadConfig(fmt.Sprintf("test_data/%s.yaml", tc.name), &actual); err != nil { t.Errorf("error while loading %s file: %v", tc.name, err) From 0095bf6c9aae035d17e9d20586801727ae161908 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 15:19:59 +0800 Subject: [PATCH 6/8] update codecov Signed-off-by: sh2 --- .github/workflows/ci.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 3ebc3d50..a74a2490 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -29,8 +29,9 @@ jobs: version: v1.50.0 args: --timeout 10m0s unit-test: - name: unit-test-coverage + name: coverage-test runs-on: ubuntu-latest + needs: [ linter ] steps: - name: Checkout sources uses: actions/checkout@v3 @@ -44,8 +45,9 @@ jobs: run: | make coverage - name: Upload coverage to Codecov - uses: codecov/codecov-action@v3 + uses: codecov/codecov-action@v2 with: + token: ${{ secrets.CODECOV_TOKEN }} fail_ci_if_error: true files: ./coverage.xml name: codecov-gtctl @@ -53,6 +55,7 @@ jobs: e2e-test: name: e2e-test runs-on: ubuntu-latest + needs: [ linter ] steps: - name: Checkout sources uses: actions/checkout@v3 From b9dd6a4bcdeb782c62e0c23b41b9c7b03803fae8 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 15:41:10 +0800 Subject: [PATCH 7/8] update README.md Signed-off-by: sh2 --- README.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/README.md b/README.md index 577782c9..53842447 100644 --- a/README.md +++ b/README.md @@ -1,5 +1,7 @@ # gtctl +[![codecov](https://codecov.io/github/GreptimeTeam/gtctl/branch/main/graph/badge.svg?token=287NUSEH5D)](https://codecov.io/github/GreptimeTeam/gtctl) + ## Overview `gtctl`(`g-t-control`) is a command-line tool for managing the [GreptimeDB](https://github.com/GrepTimeTeam/greptimedb) cluster. `gtctl` is the **All-in-One** binary that integrates multiple operations of the GreptimeDB cluster. From ecabae57862eb15ae963e1ebd0800d5c55a933f5 Mon Sep 17 00:00:00 2001 From: sh2 Date: Fri, 11 Aug 2023 17:33:25 +0800 Subject: [PATCH 8/8] update CI name Signed-off-by: sh2 --- .github/workflows/license-checker.yaml | 2 +- .github/workflows/pr-title-checker.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/license-checker.yaml b/.github/workflows/license-checker.yaml index cd61b88e..cbdbfedc 100644 --- a/.github/workflows/license-checker.yaml +++ b/.github/workflows/license-checker.yaml @@ -1,4 +1,4 @@ -name: License +name: License Checker on: push: diff --git a/.github/workflows/pr-title-checker.yaml b/.github/workflows/pr-title-checker.yaml index 86599071..0cc7032c 100644 --- a/.github/workflows/pr-title-checker.yaml +++ b/.github/workflows/pr-title-checker.yaml @@ -1,4 +1,4 @@ -name: Title +name: PR Title Checker on: [pull_request]