Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusions in Iterator-View.md #48

Open
BenWeber42 opened this issue Aug 25, 2021 · 0 comments
Open

Confusions in Iterator-View.md #48

BenWeber42 opened this issue Aug 25, 2021 · 0 comments

Comments

@BenWeber42
Copy link

After reading about the iterator view there were some confusions left which I want to mention here.
https://github.com/GridTools/concepts/blob/master/Iterator-View.md

The explanation following this paragraph is quite confusing to me:

If all the builtins are defined that way, we can get rid of using lift and deref in the stencil composition. That is probably a good idea for the frontend, but not for the intermediate level. Here the illustration. Suppose we have a stencil:

Most of the functions used there aren't defined anywhere (e.g., hannes_sum).

A bit subjective, but I find the EBNF notation a bit hard to read (maybe use space instead of comma for concatenation and use ( ... )* for repetition instead of { ... }).

Then some of the signatures are a bit confusing, e.g. what does this mean:

Stencil<Optional<V>, V> deref;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant