From cb4dfd7f77f666ad4e0bc185f9ea7c5b0d4b9308 Mon Sep 17 00:00:00 2001 From: Hannes Vogt Date: Tue, 24 Sep 2024 13:24:35 +0200 Subject: [PATCH] add version to tag --- .github/workflows/build.yml | 4 ++-- hip/Dockerfile | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index c1b59a1..2dfc12f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -168,9 +168,9 @@ jobs: docker build --progress=plain --cache-from $CR_REPOSITORY:${{ matrix.base }} - --cache-from $CR_REPOSITORY:${{ matrix.base }}-hip + --cache-from $CR_REPOSITORY:${{ matrix.base }}-rocm-6.2 --build-arg BUILDKIT_INLINE_CACHE=1 - --tag $CR_REPOSITORY:${{ matrix.base }}-hip + --tag $CR_REPOSITORY:${{ matrix.base }}-rocm-6.2 --build-arg REPOSITORY=$CR_REPOSITORY --build-arg BASE=${{ matrix.base }} hip diff --git a/hip/Dockerfile b/hip/Dockerfile index 6484bcd..f21b344 100644 --- a/hip/Dockerfile +++ b/hip/Dockerfile @@ -3,6 +3,8 @@ ARG BASE FROM ${REPOSITORY}:${BASE} LABEL maintainer="Felix Thaler " +# NOTE: If you change the ROCm version here, also change it in the build.yml to avoid overwriting the old image, +# see https://github.com/GridTools/gridtools-docker/issues/97. RUN wget https://repo.radeon.com/amdgpu-install/6.2.1/ubuntu/noble/amdgpu-install_6.2.60201-1_all.deb && \ apt-get update -qq && \ DEBIAN_FRONTEND=noninteractive apt-get install -qq -y ./amdgpu-install_6.2.60201-1_all.deb && \