Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cartesian]: Mitigation for K offset write #1684

Open
1 task
FlorianDeconinck opened this issue Oct 9, 2024 · 1 comment
Open
1 task

[cartesian]: Mitigation for K offset write #1684

FlorianDeconinck opened this issue Oct 9, 2024 · 1 comment

Comments

@FlorianDeconinck
Copy link
Contributor

FlorianDeconinck commented Oct 9, 2024

The new write offset in K means we can go out of bounds without the system being able to warn about it since extent calculation won't be able to cover those access.

Think about the degenerate case of

index = some_bad_math_that_gives_back_2349082093840
field[0, 0, index] = value

This was an iron rule for GT4Py that we now allow to be broken so we can match patterns seen regularly in physics.

To mitigate the issue, we should introduce on DEBUG a bound check, drop before every K offset write which should error out cleanly.


  • On DEBUG generate a check for bounds before K offset write
@romanc
Copy link
Contributor

romanc commented Nov 29, 2024

can't edit but I think the code should be

index = some_bad_math_that_gives_back_2349082093840
field[0, 0, index] = value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants