Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agree on function call semantics #199

Closed
mbianco opened this issue Sep 30, 2020 · 4 comments
Closed

Agree on function call semantics #199

mbianco opened this issue Sep 30, 2020 · 4 comments
Assignees
@egparedes
Labels
gt4py.cartesian Issues concerning the current version with support only for cartesian grids. module: documentation Improvements or additions to documentation
Milestone
Christmas Cleanup...

Comments

@mbianco
Copy link

mbianco commented Sep 30, 2020

We need to define and describe how calling functions from GTScript code behaves in the context of the parallel model.
@egparedes egparedes added the module: documentation Improvements or additions to documentation label Oct 1, 2020
@havogt havogt added this to the v0.2 milestone Nov 29, 2021
@jdahm
Copy link
Contributor

jdahm commented Dec 3, 2021

I recently closed a related issue: #231.

@jdahm
Copy link
Contributor

jdahm commented Dec 3, 2021

My proposal is a fairly simple semantic: the inputs are copied in the current context (only the IJ plane for the current vertical level if FORWARD or BACKWARD, otherwise on all levels), then statements are inlined such that all variables used in the function are unique temporaries (might be renamed), then return values are assigned.

cc: @twicki

@gronerl gronerl added the gt4py.cartesian Issues concerning the current version with support only for cartesian grids. label Oct 19, 2022
@jdahm
Copy link
Contributor

jdahm commented Oct 25, 2022

Agreed, the gtscript parallel model doesn't even mention 'function' 😮

@jdahm
Copy link
Contributor

jdahm commented Oct 26, 2022

Moved to GridTools/concepts#52.

@jdahm jdahm closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egparedes egparedes

Labels
gt4py.cartesian Issues concerning the current version with support only for cartesian grids. module: documentation Improvements or additions to documentation
Projects
None yet
Milestone
Christmas Cleanup 2022
Development

No branches or pull requests
5 participants
@egparedes @jdahm @mbianco @havogt @gronerl