Don't call fs_read_and_perturb for bool array

[phmarti]

pp_ser.py generates the fortran calls for write, read and read & perturb but fs_read_and_perturb is not implemented for bool arrays.

It clearly doesn't really make sense to perturb the boolean masks, but in the current state trying to serialize a bool array generates non compilable code (even if only write or read is used).

I suspect pp_ser.py doesn't know about data types, right? Couldn't fs_read_and_perturb_bool simply call fs_read_bool?

[clementval]

@phmarti As you said, it doesn't make sense to perturb a boolean array. I think your solution is fine. By the way, what is done for integer at the moment? I think it also doesn't make so much sense to perturb it ...

[havogt]

👍

[phmarti]

integer also simply call fs_read_int

[phmarti]

PR #138

How do you test the fs_read_and_perturb calls?

[clementval]

@phmarti So far looks like it's not tested

[havogt]

I would like to keep this issue open as we are introducing again code in the serialbox core which is driven by an application (pp_ser) just because it is not smart enough to use the library properly...
To be more specific: the core API is complete and descriptive by not providing perturbation for datatypes where it does not make sense. #138 introduces (more) functions which are lying about its functionality. They pretend to perturb, but don't do it...

[clementval]

Ok ... make sense