Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pp_ser data directive IF condition ignored #202

Open
phmarti opened this issue Mar 11, 2019 · 0 comments
Open

pp_ser data directive IF condition ignored #202

phmarti opened this issue Mar 11, 2019 · 0 comments

Comments

@phmarti
Copy link
Contributor

phmarti commented Mar 11, 2019

The data directive processed by pp_ser allows an IF condition to enable/disable the serialization. The regex pattern matches IF . This behaviour leads to hard to fine bugs/errors as for example:

Example 1 (wrong):
!$ser data arr=arr IF(ASSOCIATED(arr))
In this the case the condition is ignored and pp_ser doesn't generate the expected IF condition.

Example 2(correct):
!$ser data arr=arr IF (ASSOCIATED(arr))
In this case the expected code is generated including the IF condition.

There should at least be a warning when the condition is ignored!

Changing the regex to IF is most likely a bad idea as it will match too many things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant