Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for Serialization of Fortran classes, and subroutine arguments declared intent(in). #262

Open
robgpita opened this issue Sep 2, 2022 · 1 comment

Comments

@robgpita
Copy link

robgpita commented Sep 2, 2022

The non-descriptive error message :

SENA-shallow-water/build/src/fortran/serialbox_pp/module_shallow_water_model.f90:341:74:

  341 |     call fs_read_field(ppser_serializer_ref, ppser_savepoint, 'b', this%b)
      |                                                                          1
Error: There is no specific subroutine for the generic 'fs_read_field' at (1)

Displays when trying to Serialize data as part of a Fortran class - class(shallow_water_model_type), intent( in) :: this.

As well as when trying to serialize data passed as Fortran subroutine arguments declared intent(in)

SENA-shallow-water/build/src/fortran/serialbox_pp/module_shallow_water_model.f90:344:73:

  344 |     call fs_read_field(ppser_serializer_ref, ppser_savepoint, 'xps', xps)
      |                                                                         1
Error: There is no specific subroutine for the generic 'fs_read_field' at (1)

Steps to Reproduce:
clone SENA-shallow-water repository
Insert Serialbox directives into subroutines adv_nsteps_model, update_interior_model, or update_boundaries_model (within module_shallow_water_model.f90)
Build the code following README.md or build.sh

@robgpita robgpita changed the title Please add support for Serialization Fortran classes, and subroutine arguments. Please add support for Serialization of Fortran classes, and subroutine arguments declared intent(in). Sep 2, 2022
@havogt
Copy link
Collaborator

havogt commented Oct 3, 2022

Thanks for your report. Unfortunately, we cannot easily invest resources to fix problems appearing in codes outside of our collaborations.

However, this is an open source project and we happily take contributions to improve Serialbox (after signing the contributor agreement).

Alternatively, it might increase the chance to get a fix if you provide a minimal standalone example that reproduces the issue (stackoverflow style https://stackoverflow.com/help/minimal-reproducible-example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants