Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficult to read (Linux/Firefox) #2

Open
Walckiers opened this issue Jun 25, 2018 · 15 comments
Open

Difficult to read (Linux/Firefox) #2

Walckiers opened this issue Jun 25, 2018 · 15 comments

Comments

@Walckiers
Copy link

The light grey text in https://perldoc.pl/ is not easy to read
Any chance of changing css so that it renders in black ?

@Grinnz
Copy link
Owner

Grinnz commented Jun 25, 2018

What browser/OS are you using? There's no light grey text for me...

@Walckiers
Copy link
Author

Walckiers commented Jun 25, 2018 via email

@Walckiers
Copy link
Author

Screenshot lost in transmission:- trying again
61868_screenshot

@Grinnz
Copy link
Owner

Grinnz commented Jun 25, 2018

I can confirm the issue, this seems to be an issue in font rendering in Firefox on Linux. As a workaround I can make the text darker in code blocks but it still does not look good, I'm not sure there's anything else I can really do about it.

@Walckiers
Copy link
Author

Again - thank you for your quick reply.
I dont pretend to understand CSS
but fyi CTRL-SHIFT-C in my Firefox
says of the line « perl Perl»
in the above screen shot "color:#222;" ...
Perhaps a bit pale?
Full result of CTRL SHIFT C -

#wrapperlicious pre > code {
color: #222;
font: 0.9em Consolas, Menlo, Monaco, Courier, monospace;
line-height: 1.5em;
text-align: left;
text-shadow: #eee 0 1px 0;
white-space: pre-wrap;

@Grinnz
Copy link
Owner

Grinnz commented Jun 25, 2018

#222 is nearly black. It used to be #4d4d4c, which looks like this in Chrome on Linux:
mojolicious_docs_code_chrome

@Grinnz Grinnz changed the title Difficult to read Difficult to read (Linux/Firefox) Jun 25, 2018
@Walckiers
Copy link
Author

For Linux/Firefox I think it looks nice like this
screenshot
by simply doing
``
#wrapperlicious pre > code {

    font: 0.9em Consolas, Menlo, Monaco, Courier, monospace;
    line-height: 1.5em;
    text-align: left;
    text-shadow: #eee 0 1px 0;
    white-space: pre-wrap;
  }

@Grinnz
Copy link
Owner

Grinnz commented Jun 26, 2018

I don't see any difference here in Firefox by removing that color setting, as it then simply inherits the color #212529 from bootstrap CSS, which is just about the same as #222. But if your browser renders it better for some reason I see no harm in doing so.

@Grinnz
Copy link
Owner

Grinnz commented Jun 29, 2018

Please let me know if there are still font rendering issues.

@Grinnz Grinnz closed this as completed Jun 29, 2018
@dbooth-boston
Copy link

This is still a problem for me on Firefox 84.0.2 (64 bit) under Ubuntu 20.04. In particular, comment lines in perl examples are very light gray, making them quite hard to read. See the attached screenshot.
Screenshot from 2021-01-13 14-30-30

@Grinnz Grinnz reopened this Jan 13, 2021
@Grinnz
Copy link
Owner

Grinnz commented Jan 13, 2021

Thanks for the report. I am in the process of considering a new syntax highlighter which will likely change the colors used in these blocks, and will revisit after.

@dbooth-boston
Copy link

Sounds good. Thanks for the quick response!

@Grinnz
Copy link
Owner

Grinnz commented Jan 22, 2021

The new syntax highlighter has been deployed and is currently using the stack overflow light theme. Please let me know if this corrects the issue.

@Walckiers
Copy link
Author

Walckiers commented Jan 22, 2021 via email

@dbooth-boston
Copy link

That is better, though I still wish all of the normal body fonts were darker. Only bold text has good contrast, but bold is only used in a few places. The vast majority of the text is still gray-on-gray, as you can see in this screenshot, which still makes it harder to read than it should be.
perldoc-screenshot

Compare the two attached screenshots. You can see that in the second one -- the screenshot of github in which I am writing this comment -- the main text has much better contrast than in the other screenshot.
github-screenshot

Grinnz pushed a commit that referenced this issue Sep 8, 2021
Reimport Main Stream Development
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants