-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
duplicated components #16
Comments
what do you think about this task @vadim9999 |
just checking, maybe you working on something else... |
I will try to resolve this problem |
perfect. i think the first version will be just component with btw, did we chat with you about adding layout for displaying recipes? |
Sorry, I don't remember about displaying recipes |
I think needs make some simple test in react-print-pdf |
no probm - i think it was just in my head and we didn't talk about it. |
@vadim9999 can you tell me more information about what tests we should run? i can do it myself and save you some time... |
@atherdon just pass data to component |
got it. ok i think i can handle that |
i think it's obvious task
when i see this import, it's easy to find out what should be improved.
https://github.com/GroceriStar/pdf-export-component/blob/master/src/index.js#L15-L29
So right now we have 4 components that triplicated, because we have 3 different cases for displaying data.
But i also want to have 4th case to add, but this will be a problem - because a lot of code is similar.
I think we should create some sort of a component, where we'll pass a
type
property and it'll define which case we'll cover.The text was updated successfully, but these errors were encountered: