Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Cluster and Markers update #10

Closed
smartpierre opened this issue Jan 21, 2016 · 13 comments
Closed

Issue with Cluster and Markers update #10

smartpierre opened this issue Jan 21, 2016 · 13 comments

Comments

@smartpierre
Copy link
Contributor

Hi !

So I have a map with markers on it. I can paginate through the markers and they are added/removed from the map.
It works perfectly until I tried to add the cluster...

It looks like there's something wrong on the update of the markers, the Google Maps SDK is throwing this error :

screenshot from 2016-01-21 14 21 51

Here is the interesting part of the code of my vue file :

https://gist.github.com/smartpierre/b69426dcd9098c803ab3

In setMarkers, I compare the old markers with the new ones, I remove the old markers that are not in the new list and add the new that are missing (so it does not make all the markers DROP each time I refresh the map)

If you have any idea, I'll take it. Maybe I'm doing something wrong ? In the meantime I'll do without the cluster :D

@GuillaumeLeclerc
Copy link
Owner

Sadly there is nothing I can do as it is a bug of the cluster. Do you really want me to implement the quickfix ? I think it is better if you do it in your npm package descriptor.

In general I don't think it is a great idea to make a release for hotfix and then revert it two days later because the underlying bug has been fixed.

I'm really sorry about the two bugs on vue-google-maps but we need the other libraries to get fixed.

@smartpierre
Copy link
Contributor Author

Oh so it's again a problem with vue-router ?? Damn !!!

Well I can live without cluster for now, don't worry about making a hotfix !

Thank you Guillaume :)

@GuillaumeLeclerc
Copy link
Owner

No it's in the clustering library itself. There is a pull request pending. But the owner has not merged it yet :/

@GuillaumeLeclerc
Copy link
Owner

The PR is here: googlearchive/js-marker-clusterer#39

@smartpierre
Copy link
Contributor Author

Oh ok ! Well, hopefully that will be merged soon :)

@GuillaumeLeclerc
Copy link
Owner

I think so, don't need to worry. I expect you don't have a deadline soon.

@GuillaumeLeclerc
Copy link
Owner

The PR has been merged, can you confirm it works ?

@smartpierre
Copy link
Contributor Author

It is not merged yet googlearchive/js-marker-clusterer#39

@smartpierre
Copy link
Contributor Author

Although this fix has been applied https://github.com/googlemaps/js-marker-clusterer/pull/41/commits
I'll check today if it fix everything.

@smartpierre
Copy link
Contributor Author

Just tested, I do not have any errors, however it does not show any cluster :/

@GuillaumeLeclerc
Copy link
Owner

Maybe you can open a new issue since it must be a different problem

@smartpierre
Copy link
Contributor Author

Sorry I'm an idiot, it's totally working, I forgot to run webpack...

@GuillaumeLeclerc
Copy link
Owner

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants